389707 - text-transform: capitalize doesn't capitalize all words

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[Adam Guthrie]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072605 Minefield/3.0a7pre

First seen in the navigational menu on amazon.com.

Steps to reproduce:
1. Load the testcase.

Actual results:
Not all the first letters of the words are capitalized.

Expected results:
All the first letters of the words are capitalized.

This is a regression from bug 367177.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

D'oh, I should have thought of that! Hmm.

Comment 2

[Adam Guthrie]

Can we get away with shipping 1.9 with this?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, I think this should block.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The right way to implement capitalization seems to be to capitalize any letter that's preceded by the start of the block or white-space, followed by zero or more Ps, Pi, Po, Pf, Pe characters.

I think I'll do this by adding support to nsLineBreaker to return capitalization hints. But I can't do that until the patch in bug 393096 lands.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix capitalization

This is more or less what I said I was going to do.

We add functionality to nsLineBreaker to determine which characters should be capitalized. This is the right place because it has all necessary context. This requires moving the punctuation CCmap to nsContentUtils.

Then we hook that up with nsTextRunTransformations to store in nsTransformedTextRun which characters should be capitalized.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

This testcase tests punctuation and I'll check it in as a reftest.

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 285646 [details] [diff] [review]
fix capitalization

I tried this with various funky characters, and it doesn't capitalize after ZWJ ZWNJ LRM hyphen and SHY (even when breaking the line at the hyphen or SHY), but does capitalize after ZWSP, all of which seems correct to me.

Comment 8

[Reed Loden [:reed]]

The second hunk of the layout/generic/nsTextFrameThebes.cpp changes is completely bitrot. Needs new patch.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated patch

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: reftest

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

this bug might break the Japanese line-breaking. the Japanese text is sometimes broken at shortly even when the right side has space. (open parentheses sometimes force breaking the lines.) I'll check it ASAP.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

er, please ignore comment 12. the bug is older than this fix. (bug 404087)

Comment 14

[(no longer active)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050810 Minefield/3.0pre

Verified.