389724 - XPConnect doesn't support IDispatch methods/properties not listed in ITypeInfo

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Jacek Caban]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070602 Firefox/2.0.0.4
Build Identifier: 1.8

GetTypeInfo implementation is optional in IDispatch interface. Normal way of supporting IDispatch in MS scripting is calling GetIDsOfNames to get DISPID and then Invoke. It's not supported by XPConnect. I very much need it (I'm working on Wine (www.winehq.org) implementation of MSHTML on top of Gecko and I need to allow apps code to be called from JS script).

I've already started writing patch to XPConnect, but I'm a bit stuck. Its architecture is a lot different than IDispatch conception. I'd appreciate if anyone had any hint to how to implement it.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Jacek Caban]

Attachment: patch

I've written a patch that adds support for methods accessed by GetIDsOfNames. Unfortunately, XPConnect architecture doesn't allow full support. I did it by defining a method property for requested property that is not present in ITypeInfo, but is found by GetIDsOfNames. We can't even determine if it's a property or a method, so method is always assumed.

I know it's not a perfect solution, but satisfies need. The attached patch is against SeaMonkey 1.1.1. I'm happy to port it to CVS version if you are interested in it. If not, I will end up with a forked tree.

I'd appreciate any comments.

Comment 2

[Matthias Versen [:Matti]]

Comment on attachment 276676 [details] [diff] [review]
patch

Always request review from a person and don't use the wildcard.
I don't know if nejamin is the right person for this but maybe he knows who could review this

Comment 3

[Benjamin Smedberg]

This is interesting. I'm not sure what I want to do with idispatch support, but it's pretty low-priority right now. This won't make it into 3.1 for sure; I'll look at this again in a few weeks.

Comment 4

[Benjamin Smedberg]

We are going to drop idispatch support as soon as the WinCE stuff stops needing it for Flash, so I do not wish to take this patch.