ASSERTION: I don't know what scope to use!, involving HTTP auth dialogs

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: dbaron, Assigned: mrbkap)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

I'm seeing 

###!!! ASSERTION: I don't know what scope to use!: 'Error', file /builds/trunk/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 5989

probably related to HTTP auth dialogs that come up when restoring my Firefox session.  (I have a saved session that includes 4 pages that bring up HTTP auth dialogs, and they all pop up when I restore.)  Note that I got 5 assertions.
Created attachment 274121 [details]
stacks of assertions
Created attachment 274125 [details] [diff] [review]
Proposed fix

I must have been getting lazy... The assertion is harmless, I believe in the cases that we should have been hitting it. With this patch I was able to go to a site requiring HTTP authentication, and did not get any assertions.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #274125 - Flags: superreview?(jst)
Attachment #274125 - Flags: review?(jst)
I don't get any assertions (without the patch) on OS X or Linux. I suspect whatever dbaron was seeing may have been unique to startup or session restore?
Comment on attachment 274125 [details] [diff] [review]
Proposed fix

+        } else if (!(innerWin = oldWin->GetCurrentInnerWindowInternal())) {
+          scope = innerWin->GetGlobalJSObject();

This is in the code you're moving too (and I didn't see this the first time I reviewed it), but this aint right, if we ever get in here innerWin will be null.

r-
Attachment #274125 - Flags: superreview?(jst)
Attachment #274125 - Flags: superreview-
Attachment #274125 - Flags: review?(jst)
Attachment #274125 - Flags: review-
Created attachment 274207 [details] [diff] [review]
Oops, sorry
Attachment #274125 - Attachment is obsolete: true
Attachment #274207 - Flags: superreview?(jst)
Attachment #274207 - Flags: review?(jst)
Comment on attachment 274207 [details] [diff] [review]
Oops, sorry

r+sr=jst
Attachment #274207 - Flags: superreview?(jst)
Attachment #274207 - Flags: superreview+
Attachment #274207 - Flags: review?(jst)
Attachment #274207 - Flags: review+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.