389796 - ASSERTION: I don't know what scope to use!, involving HTTP auth dialogs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm seeing 

###!!! ASSERTION: I don't know what scope to use!: 'Error', file /builds/trunk/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 5989

probably related to HTTP auth dialogs that come up when restoring my Firefox session.  (I have a saved session that includes 4 pages that bring up HTTP auth dialogs, and they all pop up when I restore.)  Note that I got 5 assertions.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: stacks of assertions

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

I must have been getting lazy... The assertion is harmless, I believe in the cases that we should have been hitting it. With this patch I was able to go to a site requiring HTTP authentication, and did not get any assertions.

Comment 3

[Justin Dolske [:Dolske]]

I don't get any assertions (without the patch) on OS X or Linux. I suspect whatever dbaron was seeing may have been unique to startup or session restore?

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 274125 [details] [diff] [review]
Proposed fix

+        } else if (!(innerWin = oldWin->GetCurrentInnerWindowInternal())) {
+          scope = innerWin->GetGlobalJSObject();

This is in the code you're moving too (and I didn't see this the first time I reviewed it), but this aint right, if we ever get in here innerWin will be null.

r-

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Oops, sorry

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 274207 [details] [diff] [review]
Oops, sorry

r+sr=jst

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.