389820 - &debug=1 should work on buglist.cgi even if the query crashes

Status: NEW

(Bugzilla :: Query/Bug List, enhancement, P3)

Description

[timeless]

Attachment: let me find out

I'm tired of not being able to debug broken queries.

https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=bugs%20with%20my%20patches2&sharer_id=127400&debug=1

Is a shared query, but I can't figure out what it queries.

steps:
1. construct and save a bad query (it's easier to find someone else willing to share, paul and I both have such queries)
2. use the tried and true method of adding &debug=1 to the query to find out what it's thinking
3. stare at a useless red box that doesn't explain what's really going wrong.

expected results:
*honor* debug=1

Comment 1

[Frédéric Buclin]

joel, do you agree with changes made in Search.pm?

Comment 2

[Frédéric Buclin]

Comment on attachment 274142 [details] [diff] [review]
let me find out

bitrotten

Comment 3

[timeless]

Attachment: bits shouldn't move

Comment 4

[Frédéric Buclin]

Comment on attachment 302997 [details] [diff] [review]
bits shouldn't move


>-if ($cgi->param('debug')) {
>-    $vars->{'debug'} = 1;
>-    $vars->{'query'} = $query;
>-    $vars->{'debugdata'} = $search->getDebugData();
>-}
>+$search->addDebugData($vars, $query);

I see no reason to add debug data unconditionally.



>Index: Bugzilla/Search.pm

>+sub addDebugData {
>+    my ($self, $vars, $query) = @_;

>+    $vars->{'debug'} = 1;

This looks wrong to me. If addDebugData() is called, then the caller already has debug=1 defined.


>+sub ThrowInvalidFieldName {
>+    my ($self, $f) = @_;
>+    my %vars = {field => $f};
>+    $self->addDebugData(\%vars);
>+    ThrowCodeError("invalid_field_name", %vars);

Must be $vars everywhere, not %vars.

Also, invalid_field_name is not the only reason why Search.pm may fail. This is only a very partial fix (assuming this patch really works).

Comment 5

[timeless]

gah. could you at least read what you've quoted?

i'm changing the convention so that debug=1 is set by the callee not the caller.

Comment 6

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Comment 7

[Firefox Bug Husbandry Bot]

Removing outreachy because team does not have bandwidth to mentor this cycle.