389844 - zero_length_file: no read permission is also a possibility

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Vance Baarda]

In template/en/default/global/user-error.html.tmpl, here's the zero_length_file message:
    The file you are trying to attach is empty!

This message is incomplete because you'll get the same symptom if the browser has no read rights on the file. (For example, my browser cannot read a file owned by root with a mode of 0400.)

Here's a suggestion for a better message:
    The file you are trying to attach is empty, or you don't have permission to read it.

Comment 1

[timeless]

Attachment: improve error

Comment 2

[Vlad Dascalu]

Comment on attachment 274825 [details] [diff] [review]
improve error

We should update the title as well, but nothing short and comprehensive comes in my mind.

"No Content Detected", "Empty File Content" maybe? But those are pretty much the same as the current message title.

Comment 3

[Vlad Dascalu]

Checked in on 3.0 and trunk.

Comment 4

[timeless]

Comment on attachment 274825 [details] [diff] [review]
improve error

mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl 	1.224

BUGZILLA-3_0-BRANCH:
mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl 	1.204.2.6

as for a title, i think something along these lines, but it can get its own bug later:
No Data Sent To Server