389856 - Yahoo mail javascript events producing incorrect dialog

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Marcia Knous [:marcia]]

Attachment: Dialog produced when clicking on Empty trash in yahoo mail

Seen using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre.

1. In regular Yahoo mail account, click on either "Empty Bulk" or "Empty Trash."
2. Receive the attached screenshot.

This appears to be a recent regression, as I check Yahoo mail every day as part of my smoketest.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

This is almost certainly mine.

Comment 2

[Marcia Knous [:marcia]]

Just wanted to add that click on either the OK or cancel button renders this strange error in the Error console: Error: uncaught exception: Permission denied to set property Window.safariReturnValue. Just thought the error was interesting since it mentions safari.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Hey Johnny, this might be yours (I see this, even when I disable my wrappers).

Comment 4

[Johnny Stenback (:jst)]

Attachment: Fix dialog argument handling.

Comment 5

[Johnny Stenback (:jst)]

Fixed.

Comment 6

[Marcia Knous [:marcia]]

I am running the Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200708020808 Minefield/3.0a7pre build and I still see the issue in Yahoo mail.

Comment 7

[Johnny Stenback (:jst)]

Marcia, this works correctly for me on Win32, and for mrbkap on both Linux and Mac. Can you please double-chec that you have a build from today and report back whether you're still seeing this problem?

Comment 8

[Marcia Knous [:marcia]]

Attachment: Yahoo mail dialog in 2007080208 nightly

Comment 9

[Marcia Knous [:marcia]]

Attachment: Yahoo mail dialog in Bon Echo nightly

Comment 10

[Marcia Knous [:marcia]]

I have attached the two screenshots, my other comment didn't take. It looks like the "undefined" error is gone in today's nightly, but the dialog styling seems off. See Comment 8 and Comment 9 for screenshots.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

That's because we're showing a different type of dialog: before, they were using a more limited API to ask the question. Now, they're using showModalDialog and because of that, they control the styling. So, this is really the expected behavior.

Comment 12

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200708020808 Minefield/3.0a7pre, based on Comment 11.