389878 - Gmail , Contacts and Settings links are broken

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072620 Minefield/3.0a7pre ID:2007072620

repro
open FF
open Gmail
press on the Contacts link , left menu

result
nothing happens

Comment 1

[Peter van der Woude [:Peter6]]

regressionrange:

works in 20070726_1155_firefox-3.0a7pre.en-US.win32
fails in 20070726_1228_firefox-3.0a7pre.en-US.win32

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1185476100&maxdate=1185478079&cvsroot=%2Fcvsroot

->bug 367911

I can't add the dependency coz of [sg]

Comment 2

[Ria Klaassen (not reading all bugmail)]

And the Settings link, and more.

Comment 3

[Peter van der Woude [:Peter6]]

Labels->EditLabels is broken

Comment 4

[Egor Pelevin]

I'm not sure that it's the same problem, but official Google Calendar gadget (http://www.google.com/ig/directory?hl=en&url=calendar.xml) is broken too

Comment 5

[Egor Pelevin]

(In reply to comment #4)
> I'm not sure that it's the same problem, but official Google Calendar gadget
> (http://www.google.com/ig/directory?hl=en&url=calendar.xml) is broken too
> 

Looks like the same problem after all:

works in 20070726_1155_firefox-3.0a7pre.en-US.win32
fails in 20070726_1228_firefox-3.0a7pre.en-US.win32

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

I'm trying to figure out what's going on here. gmail is rather difficult to debug.

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072922 Minefield/3.0a7pre ID:2007072922

The problems are actually far worse.

Try Compose mail ->attach a file
result -> immediate crash.

Do I need to create another bug for the crash ?

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #7)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072922
> Minefield/3.0a7pre ID:2007072922
> 
> The problems are actually far worse.
> 
> Try Compose mail ->attach a file
> result -> immediate crash.
> 
> Do I need to create another bug for the crash ?
> 

nm, this problem seems to be gone again in the latest nightly
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre ID:2007073005

Comment 9

[Mike Schroepfer]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre ID:2007073005

Can reproduce problem on above build..

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

The problem was that I broke 'window.eval'. Because we now disallow, <not_global>.eval() will throw an exception. With XOWs, 'window' no longer refers to a true global object, instead, it refers to a wrapper, which is not a global object. This fix makes us wrap eval natives when we return them, so that we unwrap the global object before calling into eval.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 12

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073113 Minefield/3.0a7pre ID:2007073113

VERIFIED FIXED

Comment 13

[Gábor Stefanik]

This time really VERIFIED.