Closed Bug 389911 Opened 15 years ago Closed 15 years ago

Eliminate nsIScriptGlobalObject::Get/SetGlobalObjectOwner()

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

References

Details

Attachments

(2 files)

Fix.
13.66 KB, patch
peterv
: review+
peterv
: superreview+
jst
: approval1.9+
Details | Diff | Splinter Review
Updated fix.
15.45 KB, patch
Details | Diff | Splinter Review
Attached patch Fix. — — Splinter Review 
There doesn't seem to be a real reason for exposing the global object owner on the  script global object, no callers in our code need it.
Attachment #274234 - Flags: superreview?(peterv)
Attachment #274234 - Flags: review?(peterv)
Comment on attachment 274234 [details] [diff] [review]
Fix.

I'd make the nsXBLDocGlobalObject constructor take aGlobalObjectOwner as a parameter and then change the remaining SetGlobalObjectOwner functions to ClearGlobalObjectOwner. r/sr=me regardless.
Attachment #274234 - Flags: superreview?(peterv)
Attachment #274234 - Flags: superreview+
Attachment #274234 - Flags: review?(peterv)
Attachment #274234 - Flags: review+
Attached patch Updated fix. — — Splinter Review 
I did that, and I renamed SetGlobalObjectOwner() to ClearGlobalObjectOwner() (and removed the argument) in nsXULPrototypeDocument.cpp as well. Thanks for the review!
Attachment #274234 - Flags: approval1.9+
Fix checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
No longer blocks: 394042
Depends on: 394042
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.