Closed
Bug 389911
Opened 15 years ago
Closed 15 years ago
Eliminate nsIScriptGlobalObject::Get/SetGlobalObjectOwner()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
References
Details
Attachments
(2 files)
13.66 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
jst
:
approval1.9+
|
Details | Diff | Splinter Review |
15.45 KB,
patch
|
Details | Diff | Splinter Review |
There doesn't seem to be a real reason for exposing the global object owner on the script global object, no callers in our code need it.
Attachment #274234 -
Flags: superreview?(peterv)
Attachment #274234 -
Flags: review?(peterv)
Comment 1•15 years ago
|
||
Comment on attachment 274234 [details] [diff] [review] Fix. I'd make the nsXBLDocGlobalObject constructor take aGlobalObjectOwner as a parameter and then change the remaining SetGlobalObjectOwner functions to ClearGlobalObjectOwner. r/sr=me regardless.
Attachment #274234 -
Flags: superreview?(peterv)
Attachment #274234 -
Flags: superreview+
Attachment #274234 -
Flags: review?(peterv)
Attachment #274234 -
Flags: review+
Assignee | ||
Comment 2•15 years ago
|
||
I did that, and I renamed SetGlobalObjectOwner() to ClearGlobalObjectOwner() (and removed the argument) in nsXULPrototypeDocument.cpp as well. Thanks for the review!
Assignee | ||
Updated•15 years ago
|
Attachment #274234 -
Flags: approval1.9+
Assignee | ||
Comment 3•15 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
![]() |
||
Updated•15 years ago
|
Updated•3 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•