If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Eliminate nsIScriptGlobalObject::Get/SetGlobalObjectOwner()

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 274234 [details] [diff] [review]
Fix.

There doesn't seem to be a real reason for exposing the global object owner on the  script global object, no callers in our code need it.
Attachment #274234 - Flags: superreview?(peterv)
Attachment #274234 - Flags: review?(peterv)
Comment on attachment 274234 [details] [diff] [review]
Fix.

I'd make the nsXBLDocGlobalObject constructor take aGlobalObjectOwner as a parameter and then change the remaining SetGlobalObjectOwner functions to ClearGlobalObjectOwner. r/sr=me regardless.
Attachment #274234 - Flags: superreview?(peterv)
Attachment #274234 - Flags: superreview+
Attachment #274234 - Flags: review?(peterv)
Attachment #274234 - Flags: review+
(Assignee)

Comment 2

10 years ago
Created attachment 275869 [details] [diff] [review]
Updated fix.

I did that, and I renamed SetGlobalObjectOwner() to ClearGlobalObjectOwner() (and removed the argument) in nsXULPrototypeDocument.cpp as well. Thanks for the review!
(Assignee)

Updated

10 years ago
Attachment #274234 - Flags: approval1.9+
(Assignee)

Comment 3

10 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 394042
No longer blocks: 394042
Depends on: 394042
You need to log in before you can comment on or make changes to this bug.