389911 - Eliminate nsIScriptGlobalObject::Get/SetGlobalObjectOwner()

Status: RESOLVED FIXED

Description

[Johnny Stenback (:jst)]

Created attachment 274234 [details] [diff] [review]
Fix.

There doesn't seem to be a real reason for exposing the global object owner on the  script global object, no callers in our code need it.

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 274234 [details] [diff] [review]
Fix.

I'd make the nsXBLDocGlobalObject constructor take aGlobalObjectOwner as a parameter and then change the remaining SetGlobalObjectOwner functions to ClearGlobalObjectOwner. r/sr=me regardless.

Comment 2

[Johnny Stenback (:jst)]

Created attachment 275869 [details] [diff] [review]
Updated fix.

I did that, and I renamed SetGlobalObjectOwner() to ClearGlobalObjectOwner() (and removed the argument) in nsXULPrototypeDocument.cpp as well. Thanks for the review!

Comment 3

[Johnny Stenback (:jst)]

Fix checked in.