389948 - Session Restore and other browser features fail if microsummary service initialization fails during startup

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[093236]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072805 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072805 Minefield/3.0a7pre

Can not use the Session Restore, after restart the Firefox, it only show an blank tab and the "Recently Closed Tabs" menu which under the History menu has been disabled.

I found that after I closed the Firefox,rename the "microsummary-generators" folder and then open the Firefox, it works again.

Reproducible: Always

Steps to Reproduce:
1.Choose "Show my windows and tabs from last time" in the Startup of the Options
2.Exit Firefox
3.Open the Firefox again
Actual Results:  
Only show a blank tab

Expected Results:  
Restore the windows and tabs from last time

Rename the "microsummary-generators" folder and then open the Firefox, it works again.

Comment 1

[Steve England [:stevee]]

I see this too. Probably related to bug 389943.

Comment 2

[mozilla]

Starting the browser with microsummaries in place, error console displays two errors:

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIXMLHttpRequest.setRequestHeader]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Program%20Files/MinefieldPlaces/components/nsMicrosummaryService.js :: MSR_load :: line 1991"  data: no]
Source File: file:///C:/Program%20Files/MinefieldPlaces/components/nsMicrosummaryService.js
Line: 1991

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: delayedStartup :: line 943"  data: no]

If I delete them, I don't.

Comment 3

[Steve England [:stevee]]

Note: This bug only applies to manually added microsummaries that are present in your ../<firefox profile>/microsummary-generators directory. If you add a microsummary using firefox's UI then things are fine.

Works 20070726_1513_firefox-3.0a7pre.en-US.win32.zip
Broken 20070726_1530_firefox-3.0a7pre.en-US.win32.zip

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1185487980&maxdate=1185488999

Due to bug 389508

Comment 4

[Steve England [:stevee]]

Adding relnote keyword at request of schrep for gp alpha 7.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This is caused by bug 389943, the microsummary code throws an exception before the session restore code can be executed. We should consider moving the session restore code earlier in delayedStartup so that exceptions in other parts of less-critical code (like microsummaries) don't cause session store to fail. I'll file a bug on that.

Comment 6

[Bill Gianopoulos [:WG9s]]

Probably obvious, but this also breaks "Undo Close Tab".

Comment 7

[Steve England [:stevee]]

I think this may also break the ability of firefox to remember the font size across the same domain. (Change font size in this bug, open another bug in a new tab, and the new tab isn't at the font-size of this bug)

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: don't hork startup if microsummary service initialization fails

Fixing the microsummary service will happen in bug 389943. We shouldn't disrupt startup if it fails, though.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 274315 [details] [diff] [review]
don't hork startup if microsummary service initialization fails

r=me, but leave the comment outside of the try/catch

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Landed with a=mconnor over IRC.
mozilla/browser/base/content/browser.js 	1.819

Comment 11

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/2007072904 Minefield/3.0a7pre ID:2007072904
--> VERIFIED
Session restore now works for me, changing font size is persistent across different tabs on the same site and History > Recently Closed Tabs works too.