390007 - clean up nsPlacesTransactionsService.js and improve test_placesTxn.js

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

clean up nsPlacesTransactionsService.js and improve test_placesTxn.js

ideas:

1) use this.id or this._id consistently (not both, this is error prone, see #389202)

2) add tests to test_placesTxn.js for creating items and livemarks with annotations.  for bug #389202, I've added one for creating folders with an annotation for the description.

3) add tests to test_placesTxn.js for testing child transactions.

Comment 1

[Dietrich Ayala (:dietrich)]

(In reply to comment #0)
> clean up nsPlacesTransactionsService.js and improve test_placesTxn.js
> 
> ideas:
> 
> 1) use this.id or this._id consistently (not both, this is error prone, see
> #389202)

.id is modified externally when the transaction is a child transaction, so we should standardize on it instead of ._id.

Comment 2

[(not reading, please use [e-mail] instead)]

> .id is modified externally when the transaction is a child transaction, so we
> should standardize on it instead of ._id.

thanks for looking into this.  

does that mean that for certain child transactions, where we currently use ._id, something is broken?

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 4

[Marco Bonardo [:mak]]

nsPlacesTransactionsService.js is dead