Last Comment Bug 390185 - signtool error message wrongly uses the term "database"
: signtool error message wrongly uses the term "database"
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: trunk
: All All
: P3 minor (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
:
Mentors:
http://lxr.mozilla.org/security/sourc...
Depends on:
Blocks: 390184
  Show dependency treegraph
 
Reported: 2007-07-30 12:41 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2007-08-01 22:51 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (765 bytes, patch)
2007-07-30 15:24 PDT, Nelson Bolyard (seldom reads bugmail)
neil.williams: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2007-07-30 12:41:04 PDT
In signtool's function 
if the call to 
fails for any reason, signtool outputs the error message 
    "the cert \"%s\" does not exist in the database"
                                    ^^^^^^^^^^^^^^^
This is misleading, because it may not have looked "in the database"
AT ALL.  The phrase "in the database" should be removed.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-07-30 12:42:45 PDT
Correction:
In signtool's function create_pk7, if the call to PK11_FindCertFromNickname
fails for any reason ...

See http://lxr.mozilla.org/security/source/security/nss/cmd/signtool/sign.c#270
Comment 2 Nelson Bolyard (seldom reads bugmail) 2007-07-30 15:24:20 PDT
Created attachment 274528 [details] [diff] [review]
patch v1

This should do it
Comment 3 Neil Williams 2007-08-01 15:29:30 PDT
Comment on attachment 274528 [details] [diff] [review]
patch v1

r+
Comment 4 Nelson Bolyard (seldom reads bugmail) 2007-08-01 22:51:45 PDT
Checking in cmd/signtool/sign.c; new revision: 1.13; previous revision: 1.12

Note You need to log in before you can comment on or make changes to this bug.