signtool error message wrongly uses the term "database"

RESOLVED FIXED in 3.12

Status

NSS
Tools
P3
minor
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

In signtool's function 
if the call to 
fails for any reason, signtool outputs the error message 
    "the cert \"%s\" does not exist in the database"
                                    ^^^^^^^^^^^^^^^
This is misleading, because it may not have looked "in the database"
AT ALL.  The phrase "in the database" should be removed.
(Assignee)

Comment 1

10 years ago
Correction:
In signtool's function create_pk7, if the call to PK11_FindCertFromNickname
fails for any reason ...

See http://lxr.mozilla.org/security/source/security/nss/cmd/signtool/sign.c#270
(Assignee)

Comment 2

10 years ago
Created attachment 274528 [details] [diff] [review]
patch v1

This should do it
Attachment #274528 - Flags: review?
(Assignee)

Updated

10 years ago
Assignee: nobody → nelson
Priority: -- → P3
Target Milestone: --- → 3.12
(Assignee)

Updated

10 years ago
Attachment #274528 - Flags: review? → review?(neil.williams)

Comment 3

10 years ago
Comment on attachment 274528 [details] [diff] [review]
patch v1

r+
Attachment #274528 - Flags: review?(neil.williams) → review+
(Assignee)

Comment 4

10 years ago
Checking in cmd/signtool/sign.c; new revision: 1.13; previous revision: 1.12
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.