All users were logged out of Bugzilla on October 13th, 2018

PK11_FindCertFromNickname should find nicknames with colons in certDB

RESOLVED WONTFIX

Status

P2
normal
RESOLVED WONTFIX
11 years ago
11 years ago

People

(Reporter: nelson, Assigned: nelson)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

When PK11_FindCertFromNickname is called with a nickname with a colon in it,
it tries to find a token with the name before the colon, and if that fails,
it gives up.  It should attempt to retry the operation, looking for the whole
original nickname string in the softoken.
(Assignee)

Comment 1

11 years ago
Created attachment 274551 [details] [diff] [review]
patch v1

This patch is mutually exclusive with the patch attached to bug 390187.
One of these bugs should be marked WONTFIX, I think.
Please vote for one.
Attachment #274551 - Flags: superreview?(rrelyea)
Attachment #274551 - Flags: review?(neil.williams)
(Assignee)

Comment 2

11 years ago
Created attachment 274557 [details] [diff] [review]
patch v2, fix both functions

There are two functions in this source file that both have the same problem.
This patch fixes them both.
Assignee: nobody → nelson
Attachment #274551 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #274557 - Flags: superreview?(rrelyea)
Attachment #274557 - Flags: review?(neil.williams)
Attachment #274551 - Flags: superreview?(rrelyea)
Attachment #274551 - Flags: review?(neil.williams)
(Assignee)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.11.8

Comment 3

11 years ago
I prefer to fix bug 390187 rather than this one. It has always been the case that the string before the first colon signifies the token in nicknames. Let's not try to change it. As you pointed out, the problem can be worked around by prefixing the softoken token name.
(Assignee)

Comment 4

11 years ago
OK, Julien and Bob both voted for the other bug/fix.  so, WONTFIX
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX

Updated

11 years ago
Attachment #274557 - Flags: superreview?(rrelyea)

Comment 5

11 years ago
Comment on attachment 274557 [details] [diff] [review]
patch v2, fix both functions

cancelling reqview request
Attachment #274557 - Flags: review?(neil.williams)
You need to log in before you can comment on or make changes to this bug.