390228 - Redragging over empty text field doesn't show drag caret, except for the last text field

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase.

To reproduce:
- Select some text to drag, then drag it over the text inputs and textareas.

Notice that when dragging over them, you see a (non-blinking) caret the first time, but not when you drag a second time over them.
What's interesting is that the last text field doesn't seem to suffer from this.

This regressed between 2006-04-17 and 2006-04-18, I think a regression from bug 287813.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This fix also fixes the caret flicker problem by not erasing the caret automatically each time editor asks it to. The actual problem here was that we weren't telling our presShell what the current caret was, which meant that it wasn't drawing it.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 275181 [details] [diff] [review]
Proposed fix

This patch fixes the drag indicator for empty textfields.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 275181 [details] [diff] [review]
Proposed fix

a1.9=dbaron

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082111 Minefield/3.0a8pre