390280 - Support ARIA wairole:img

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The wairole:img is something authors can put on a container that creates an image.

For example this is used when one image is made of many tiles, so that the entire structure is exposed as a single image instead of many.

Comment 1

[Aaron Leventhal]

Attachment: Tiled image testcase

Comment 2

[Aaron Leventhal]

Attachment: Correct testcase

Comment 3

[Aaron Leventhal]

Attachment: Add img role to nsARIAMap. Use new internal role for non-leaf (image area) images that have subtrees. Add MustPrune() method for ATK that we can expand later.

Ginn, this needs testing on Linux.

Depending on what we decide in bug 390194, we may decide to expand MustPrune() to include more types of leaf elements. We may even want MustPrune() to be the same for all APIs.

Pruning must be done in platform layer instead of in XP nsIAccessible tree, because nsHyperTextAccessible needs children to support its methods.

Comment 4

[Aaron Leventhal]

Attachment: Also add other missing roles from spec, it's just as good to do it now

Comment 5

[Martin Schröder [:mschroeder]]

Aaron, I think bug 390194 in comment#3 and on Blocks list is a typo. It a Calendar bug.

Comment 6

[Aaron Leventhal]

Attachment: Don't forget to add to role string table

Comment 7

[Aaron Leventhal]

Sorry, bug 390154. Thanks.

Comment 8

[alexander :surkov (:asurkov)]

Usually we redefine crossplatform behaviour in wrap classes. It's not totally correct (because AT based on gecko will have different API implementation on different platforms) but I think we should have an ability to strict a children (MustPrune()) in cross platform code too and then MustPrune() will be redefined in wrap classes if needed.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #8)
> Usually we redefine crossplatform behaviour in wrap classes. It's not totally
> correct (because AT based on gecko will have different API implementation on
> different platforms) but I think we should have an ability to strict a children
> (MustPrune()) in cross platform code too and then MustPrune() will be redefined
> in wrap classes if needed.
> 

Probably you shown a good example based on ROLE_GRAPHIC. If we do not need children on mac or os2 for it then I think we shouldn't have them in crossplatform part too.

Comment 10

[Ginn Chen]

Comment on attachment 274613 [details] [diff] [review]
Don't forget to add to role string table

accessible/src/atk/nsAccessibleWrap.h
static PRBool MustPrune(nsIAccessible *aAccessible); should be moved to public

accessible/src/base/nsAccessibilityService.h
   "combobox listitem"    //ROLE_COMBOBOX_LISTITEM
+  "image map"            //ROLE_IMAGE_MAP

comma is missing after "combobox listitem"

Comment 11

[Aaron Leventhal]

Okay, I'll add the comma at checkin time.

Comment 12

[Aaron Leventhal]

Comment on attachment 274613 [details] [diff] [review]
Don't forget to add to role string table

Need for full ARIA support.

Comment 13

[alexander :surkov (:asurkov)]

Attachment: max bustage fix

Comment 14

[alexander :surkov (:asurkov)]

Joel, does this patch help?

Comment 15

[Joel Craig]

Yes, that works!

Comment 16

[Aaron Leventhal]

Comment on attachment 275226 [details] [diff] [review]
max bustage fix

My mistake, but:
s/ROLE_IMAGE_MAP/ROLE_GRAPHIC

Otherwise it's removing the links from the image children. We only want it to remove the tile children from a flat image (ROLE_GRAPHIC).

Comment 17

[alexander :surkov (:asurkov)]

Comment on attachment 275226 [details] [diff] [review]
max bustage fix

checked in