Exports needed for SQLite on OS/2

RESOLVED FIXED

Status

()

Toolkit
Storage
--
blocker
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

Trunk
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Shawn likes it better if one opens new bugs for OS/2 problems, so here we go. This is about the build break from bug 306907#c74. Will attach a new, hopefully better, patch in a moment.
(Assignee)

Comment 1

11 years ago
Created attachment 274618 [details] [diff] [review]
use windows .def file as base for OS/2 add_defs

If I reformat the Windows .def file a little I can easily use it as an input file to create the exports list for OS/2 (which needs an extra underscore prepended). I didn't actually find a guide for Windows .def files so I hope that like on OS/2 I can move the DATA directive to before the EXPORTS line.
Attachment #274618 - Flags: review?(sdwilsh)
Comment on attachment 274618 [details] [diff] [review]
use windows .def file as base for OS/2 add_defs

I'm not the appropriate person to review this.  Probably bsmedberg.

Also, please get someone on windows to test this.
Attachment #274618 - Flags: review?(sdwilsh)
(Assignee)

Comment 3

11 years ago
Michael, before I submit this to review again, you seem to be the one who added the
   sqlite3Os DATA
line to sqlite.def originally. Do you think moving the DATA around like in this patch will work or do you have another idea?

Comment 4

11 years ago
(In reply to comment #3)
> Michael, before I submit this to review again, you seem to be the one who added
> the
>    sqlite3Os DATA
> line to sqlite.def originally. Do you think moving the DATA around like in this
> patch will work or do you have another idea?
> 
It does seem to work, but ssl.def (http://lxr.mozilla.org/mozilla/source/security/nss/lib/ssl/ssl.def) didn't need to do this, which is where I looked at originally to add the sqlite3Os DATA line. Don't have any other ideas though..
(Assignee)

Comment 5

11 years ago
Do you perhaps know an (online) documentation of the parameters in a Windows .def file? Just to confirm that this still does what it is supposed to do?
(Assignee)

Comment 6

11 years ago
Created attachment 274799 [details] [diff] [review]
[checked in] Simpler way

Actually, I found an easier way to do everything with one sed command which also strips off the DATA part without the need to move that around.
Attachment #274618 - Attachment is obsolete: true
Attachment #274799 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #274799 - Flags: review? → review?(benjamin)

Comment 7

11 years ago
(In reply to comment #5)
> Do you perhaps know an (online) documentation of the parameters in a Windows
> .def file? Just to confirm that this still does what it is supposed to do?
> 

http://support.microsoft.com/kb/132044/
Peter, I'm really no expert but your solution now seems to be more appropriate as the DATA behind sqlite30s has sth to do with the __declspec(dllimport) declared in http://mxr.mozilla.org/seamonkey/source/db/sqlite3/src/sqlite3file.h
I built with your last patch on windows but saw an output that the standalone DATA statement would be ignored (probably with the new patch obsolete to post the concrete warning) though the build went fine and started.
Next question, do we want also declspec(dllimport)

(Assignee)

Comment 8

11 years ago
As always I'm a bit confused about the __declspec stuff but if I understand the docs correctly (like item 2 on http://support.microsoft.com/kb/90530/) should sqlite3Os in sqlite3file.h not be decorated with __declspec(dllexport) instead of dllimport? Then it would not need to be listed in the .def file at all.

Comment 9

11 years ago
Comment on attachment 274799 [details] [diff] [review]
[checked in] Simpler way

This has got to be one of the grosser hacks in our build system.
Attachment #274799 - Flags: review?(benjamin) → review+
(Assignee)

Comment 10

11 years ago
Comment on attachment 274799 [details] [diff] [review]
[checked in] Simpler way

Checked into trunk.

Michael Wu (or somebody else), any remarks on comment 7/comment 8 or should I close this bug?
Attachment #274799 - Attachment description: Simpler way → [checked in] Simpler way

Comment 11

11 years ago
(In reply to comment #10)
> (From update of attachment 274799 [details] [diff] [review])
> Checked into trunk.
> 
> Michael Wu (or somebody else), any remarks on comment 7/comment 8 or should I
> close this bug?
> 
No idea (WRT comment 7/comment 8). I just copied what ssl did to make sqlite work..
(Assignee)

Comment 12

11 years ago
OK then. What we have now works, let's leave it at that.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.