390300 - Open new event dialog from the today pane -> wrong default event length

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- open the new event dialog with a doubleclick in the today pane (agenda area)

RESULT:
=======

- the event length is 00:00

EXPECTED RESULT:
================

- the event length should be the default (60 minutes, see 'Preferences -> Lightning -> General -> "Default Event Length")

REPRODUCIBLE:
=============

- always

Comment 2

[Martin Schröder [:mschroeder]]

Confirmed using Tb 2.0.0.7pre (20070817) + Lightning 0.7pre (2007081795)
on WinXP.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: rev0 - omit end date when calling createEventWithDialog()

createEventWithDialog() will automatically calculate the correct end date from the start date and preference calendar.event.defaultlength.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/content/calendar-item-editing.js&rev=1.42&mark=97-100#90

Comment 4

[Martin Schröder [:mschroeder]]

Marking blocking 0.7 because this is bad user experience (decided on QA chat) and has already a patch.

Comment 5

[Martin Schröder [:mschroeder]]

Comment on attachment 277920 [details] [diff] [review]
rev0 - omit end date when calling createEventWithDialog()

Stealing review ;). r=mschroeder

Daniel, you asked some time ago, if I want to do reviews. Here is my first one, and I hope this is okay with you.

Comment 6

[Daniel Boelzle [:dbo]]

No problem; checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 7

[Stefan Sitter [:ssitter]]

I asked Berend in Bug 388414 Comment #34 to incorporate the changes into his patch too because he touches the same lines of code.

Comment 8

[Andreas Treumann]

Checke in Lightning build 2007091303 -> VERIFIED

Comment 9

[Stefan Sitter [:ssitter]]

This issue has been regressed again in 0.8pre, see Bug 418115 Comment #2 and following.