390374 - remove deprecated PBE functions

Status: NEW

(NSS :: Libraries, enhancement, P5)

Description

[glen beasley]

Deprecated PBE fucntions: PBE_CreateContext, PBE_GenerateBits, and PBE_DestroyContext, Use the PBE functions in pk11func.h

http://mxr.mozilla.org/security/source/security/nss/lib/pk11wrap/secpkcs5.h#72

http://mxr.mozilla.org/security/ident?i=PBE_CreateContext

These three deprecated functions are private. If we replace it's possible we could remove the old 
code.

Comment 1

[Manish [:manishkk]]

Need to remove these lines?
https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/pk11wrap/secpkcs5.h#49-57

Comment 2

[glen beasley]

you would remove
https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/pk11wrap/secpkcs5.h#43-57
and
https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/pk11wrap/pk11pbe.c#963-1082
to remove the dead code - I would hope after 12 years, there are no applications using that code.

Comment 3

[Manish [:manishkk]]

Attachment: Patch_Bug390374

Please review!

Thanks

Comment 4

[Manish [:manishkk]]

Attachment: Bug 390374 remove deprecated PBE functions

Comment 5

[Manish [:manishkk]]

Attachment: Bug 390374 remove deprecated PBE functions

Comment 6

[Kai Engert [:KaiE:]]

The functions are exported in def files. IMO the ABI promise doesn't allow us to remove any exported functions in NSS 3.x releases. (They could be fully released if NSS ever migrates to a major new version 4.x)

Nobody might have noticed the code comments that declared the functions as deprecated. Has the intent to deprecate ever been announcement to the community?

If you believe there's a good reason to remove this code, I'd suggest to keep the functions, but remove their function bodies, and only return a failure, e.g. NULL.