Closed Bug 390488 Opened 14 years ago Closed 14 years ago
[FIXr]Event listeners should have access to the JS callstack
As of Firefox 18.104.22.168 rc1 , chrome event listeners can no longer obtain the stacktrace that led to the event, whether they use (new Error).stack or arguments.callee.caller[.caller...]. These were useful for dump debugging and even in extension code to adjust behaviour based on the source of events. The change was since Firefox 22.214.171.124 rc3 , possibly due to bug 326777 . According to Boris Zbarsky on IRC, this effect was unintended however, and event listeners should continue to be able to obtain stack traces. I've attached a tiny testcase extension, just install then click Tools->Test Event Stacktraces (an extension was the easiest way to test with chrome privileges). : http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/126.96.36.199-candidates/rc1/unsigned/firefox-188.8.131.52.en-US.win32.zip : http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/184.108.40.206-candidates/rc3/unsigned/firefox-220.127.116.11.en-US.win32.zip : Relevant checkins are: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=bzbarsky%25mit.edu&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-10+14%3A17&maxdate=2007-07-10+14%3A24&cvsroot=%2Fcvsroot
So this is a regression from bug 371858 of sorts: when event handling pushes its JSContext on the stack, we save off its stackframe, even though this JSContext is already what's at the top of the stack. It's easy enough to detect this case and not save off the stack, and I think for branch we should do exactly that...
Summary: Event listeners should → Event listeners should have access to the JS callstack
I've added a simpler content only testcase to the URL field. This simulates a click, and checks that it can detect that it did so.
The idea here is to not clear out the JS frame stack if the context being pushed is what's already at that top. We'd still clear it when pushing a null context, of course.
Priority: -- → P2
Summary: Event listeners should have access to the JS callstack → [FIX]Event listeners should have access to the JS callstack
Target Milestone: --- → mozilla1.9 M8
Attachment #274833 - Flags: superreview?(brendan) → superreview+
Summary: [FIX]Event listeners should have access to the JS callstack → [FIXr]Event listeners should have access to the JS callstack
Comment on attachment 274833 [details] [diff] [review] Proposed fix Fix for a regression from one of our security fixes. Risk of a security regression is small, and there is basically no risk of functionality regressions.
Attachment #274833 - Flags: approval1.9?
Attachment #274833 - Flags: approval1.9? → approval1.9+
Checked in, with the tests.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 274833 [details] [diff] [review] Proposed fix approved for 18.104.22.168 and 22.214.171.124, a=dveditz
You need to log in before you can comment on or make changes to this bug.