Closed Bug 390592 Opened 17 years ago Closed 17 years ago

Firefox fails to load all homepages if one of them is a no more existing local dir

Categories

(Firefox :: Tabbed Browser, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED DUPLICATE of bug 356571

People

(Reporter: ria.klaassen, Assigned: mak)

References

Details

(Keywords: regression)

Attachments

(1 obsolete file)

Steps to reproduce: - New profile, start Firefox - Create a folder on your desktop and call it Downloads - In Options, set the default download folder to Downloads - Drag Downloads from your local disk into the open browser window - Load 3 other pages as new tabs - Set all 4 tabs as homepages - Rename folder Downloads - Restart the browser Result: only one message "File not found" but Firefox fails to load the other 3 pages Expected result: all 4 tabs should be loaded. Regression between 2006-01-20 13 and 2006-01-20 21: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-01-20+12%3A00&maxdate=2006-01-20+22%3A00 Could be caused by bug 308396. The bug is also present on branch. Sorry for the complicated Steps to reproduce, but they all all required.
Attached patch add try catch in loadTabs (obsolete) — Splinter Review
gBrowser.loadTabs(aURIString.split("|"), false, true); sends an exception on load of the first uri, that is catched and it stop. Before it was using a for cycle with gBrowser.addTab(urls[i]); and catching on each iteration So adding try catch inside loadTabs does the trick
Attachment #274901 - Flags: review?
Attachment #274901 - Attachment description: add try catch inloadTabs → add try catch in loadTabs
don't know who is the right reviewer for tabbed brower, mano? Also, this needs check-in if approved
Attachment #274901 - Flags: review? → review?(mano)
editing title, this happens with every non existing local dir temporary taking bug waiting for review (or something)
Status: NEW → ASSIGNED
Summary: Firefox fails to load all homepages if one of of them is your download dir, points to your local disk and can't be found → Firefox fails to load all homepages if one of them is a no more existing local dir
Assignee: nobody → mak77
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Comment on attachment 274901 [details] [diff] [review] add try catch in loadTabs Please feel free to move this patch over to the other bug.
Attachment #274901 - Attachment is obsolete: true
Attachment #274901 - Flags: review?(mano)
Verified dup
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: