390697 - Add color profile support pref to content dialog

Status: NEW

(Firefox :: Settings UI, defect)

Description

[Stuart Parmenter]

Attachment: fix

We now have color profile support for colors and images.  Support is currently disabled by default and we may want to enable it at some point during this milestone but whatever the default there are good reasons to set it the other way.  I predict that photo folks will want it on no matter what and that some people may want it off because their plugin (flash) colors won't match up with their CSS/image colors.  I think it useful to expose this pref for those reasons.  I have no strong feelings for the text of the pref in the dialog so if you want to change it thats fine with me.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Deb noticed that right now this pref seems to require a restart to take effect. Can that be changed? If not, that will change the UI requirements for a pref.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #1)
> Deb noticed that right now this pref seems to require a restart to take effect.
> Can that be changed? If not, that will change the UI requirements for a pref.

Not easily, unfortunately.  It could take effect immediately, but it would only affect images that are loaded after the pref is changed.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 274992 [details] [diff] [review]
fix

I think that we should actually try with the default for this pref being true (guess that's a seperate bug, though) and see if we get a lot of error reports of broken pages.

As for the UI, this is the right location, but there needs to be some indication that the pref isn't instant-apply. A notificationbox would probably look ugly, so as much as I hate to say it, a dialog should probably pop with:

"This preference will be applied the next time %s starts."

and buttons for "OK" (default) and "Restart Now"

Comment 4

[Stuart Parmenter]

it would be really nice to expose this in the ui.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

It would; got someone to write the patch? We either need indication that it's not instant apply, or the ability to make it instant apply.

Comment 6

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: notification bar WIP

This adds a notificationbox to all prefwindows, and makes use of it here to alert the user about the need to restart. It doesn't work very well, though, because the notification bar pushes down the prefpane content to below the bottom border of the screen. It also notifies any time the pref is changed by the user, because we can't tell whether or not CMS is currently enabled from script. Could keep track of the value when the pref dialog was opened, and only notify when changing away from that value, I guess, but even that won't work in all cases.

Comment 8

[Bobby Holley (:bholley)]

We're hoping to turn on color management for the alpha this coming monday. What's the status on the color profile pref? Can this be put together to work reliably before the freeze?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

My patch has the problems mentioned in comment 7 - if someone can fix those it's probably sufficient. 

Comment 10

[Bobby Holley (:bholley)]

backend pref is all set up - what's the progress on the prefpane?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Presumably if there were progress it would be in this bug :) I'm not working on it, and this bug is assigned to [e-mail].