390719 - GTK textboxes should highlight according to theme when focused

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Ventnor]

Attachment: Patch

In some GTK themes, focused textboxes have their borders highlighted when they're focused. We don't do that in the current widget implementation, but now I've figured out why.

Its a simple case of setting some flags, so its a very low-risk patch and seems to fix the last (as I know of) obvious issue with GTK native theming.

Comment 1

[Michael Ventnor]

I probably should also mention that in this patch I did a little bit of code cleanup with textboxes. Behaviour won't change, though.

Comment 2

[Michael Ventnor]

Roc, can you do the review today?

Comment 3

[Michael Ventnor]

Comment on attachment 275030 [details] [diff] [review]
Patch

I'll need someone to check this in on my behalf (when/if blocking-1.9 is granted)

The risk is as low as you can get, basically its minor code shuffling and adding a couple of lines which sets a flag. Thats it. This will cause the focused textbox to have its border highlighted on themes that support it, which not only improves user experience, but it is #1 on the recent list "9 things Firefox should steal from Safari", if thats any encouragement :-)

Comment 4

[Michael Ventnor]

(In reply to comment #3)
> (From update of attachment 275030 [details] [diff] [review])
> I'll need someone to check this in on my behalf (when/if blocking-1.9 is
> granted)

Er, approval-1.9, not blocking.

Comment 5

[Dão Gottwald [:dao]]

Btw, does somebody know if this is already working on Windows Vista, or if there's a similar bug?

Comment 6

[Michael Ventnor]

Stuart or vlad, I heard that you have the authority to give approval-1.9 on a patch like this?

Comment 7

[Phil Ringnalda (:philor)]

widget/src/gtk2/gtk2drawing.c 1.28