390747 - POST keyword bookmarks stop working after a restart

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

POST keyword bookmarks don't get imported properly from earlier Firefox versions

this comes from Will Levine, in bug #329842

I'll work on a test case to confirm

Comment 1

[(not reading, please use [e-mail] instead)]

will, this is working for me.

in fx 2, I created a post keyword for http://www.howstuffworks.com/ and the migrated fine to the trunk.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre

Do you have a specific test case?

Comment 2

[Will Levine]

OK, sorry for the false alarm, this isn't actually the problem. When I upgraded to trunk a week or so ago POST keywords stopped working so I assumed it was problem in importing, but this isn't actually the case.

Here's what actually happens: I create a new POST keyword bookmark and test it out a few times, it works fine. But as soon as I restart Firefox, all of the keywords stop working.

I can reproduce this 100% of the time with my own well-used, messy profile. However, when I try to reproduce it with a clean profile, the keywords seem to work some of the time, but not all of the time.

The two sites I'm using for testing are
http://www.thebaseballcube.com/
http://allmusic.com/
though I doubt it makes a difference.

And when I say that the keywords don't work, what I mean is that they call up the search page, but don't send the search terms.

Comment 3

[(not reading, please use [e-mail] instead)]

Will, which build are you using? 

"But as soon as I restart Firefox, all of the keywords stop working."

this sort of sounds like bug #389808, but keywords aren't annotations.

Comment 4

[Will Levine]

Just upgraded to the most recent build and still seeing this problem.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080309 Minefield/3.0a8pre

Can anyone else confirm this? I'm seeing it consistently now, even with a fresh profile.

Comment 5

[Tracy Walker [:tracy]]

Seth and Will I can confirm this with several POST keyword searches including the howstuffworks site.  Using a fresh profile, verything works fine with the keyword search until you restart the app. Then the results portion of the page is just blank. In the case of howstuffworks I searched the exact same topic, "compost" before and after restart. Before restart I get sponsored and other results. But after restart I got:

Your search '' did not match any HowStuffWorks documents.

No HowStuffWorks pages were found containing '' 

Suggestions:

    * Make sure all words are spelled correctly.
    * Try different keywords.
    * Try more general keywords.

We're not passing a search string.

Comment 6

[(not reading, please use [e-mail] instead)]

I can reproduce this.  Taking and investigating.

Comment 7

[(not reading, please use [e-mail] instead)]

zoinks, it appears that we are using 0 (EXPIRE_SESSION) as the annotation
expiration, instead of EXPIRE_NEVER

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 281697 [details] [diff] [review]
patch

r=me, thanks Seth.

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

thanks for the quick review, Dietrich.

Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.66; previous revision: 1.65
done

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223

Test cases were added to litmus for regression testing across 3.x:

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7597

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7598

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv