390756 - Bugzilla turns unusable after adding another language

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Marc Schumann [:Wurblzap]]

This is a regression of bug 374331.

After installing a second language and making Bugzilla aware of it by setting its language param, Bugzilla crashes on every page. This is because Bugzilla/Template/Plugin/Hook.pm calls Bugzilla::Template::sortAcceptLanguage, which was removed by bug 374331.

Steps to reproduce:
1. mkdir template/xx/
2. mkdir template/xx/custom/
3. Set language param to "en,xx"

Comment 1

[Frédéric Buclin]

This is a regression and makes our localization work useless if Bugzilla is unable to handle other languages correctly.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

This would seem to be the smallest fix possible.

Bug 365378 is probably the broader fix.

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 275112 [details] [diff] [review]
v1

(In reply to comment #2)
> This would seem to be the smallest fix possible.

Indeed. I think the re-working you mention in your code comment should be part of 3.2. Can you please file a bug for this?

> Bug 365378 is probably the broader fix.

No, bug 365378 is in fact being blocked by this bug here. (I came accross this bug here while working on bug 365378.)

With your patch, I'm being told "Not a GLOB reference at
[My Perl]/site/lib/Template/Provider.pm line 646" after having added a second language code to the language param. I have Template-Toolkit version 2.18.

Comment 4

[Frédéric Buclin]

Any progress on this bug?

Comment 5

[Max Kanat-Alexander]

Comment on attachment 275112 [details] [diff] [review]
v1

I can't reproduce that problem, following the exact steps in comment 0, with Template-Toolkit 2.15 or 2.19, when this patch is applied.

Comment 6

[Frédéric Buclin]

Comment on attachment 275112 [details] [diff] [review]
v1

This patch fixes the missing routines error message, so r=LpSolit. Now, even with this patch applied, I get the error described in comment 3. But that's another (old) bug, see bug 335354. Bugzilla 3.0.1 is affected by bug 335354 as well; I tested right now. Oh, and running checksetup.pl while everything is broken won't help due to bug 360626.

One word to summarize all this: broken!

Comment 7

[Frédéric Buclin]

Let's check in this patch; it will unhide bug 335354 and bug 360626.

Comment 8

[Marc Schumann [:Wurblzap]]

Comment on attachment 275112 [details] [diff] [review]
v1

Ok, I can see that.

Comment 9

[Max Kanat-Alexander]

Checking in Bugzilla/Template/Plugin/Hook.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template/Plugin/Hook.pm,v  <--  Hook.pm
new revision: 1.8; previous revision: 1.7
done

Comment 10

[Marc Schumann [:Wurblzap]]

I filed bug 392943 to follow up the issue of comment 2 and comment 3.