390771 - Want to be able to "switch" profile

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[[e-mail]]

I'd like to emulate SeaMonkey's profile switching. My idea is as follows:
1. Register the toolkit profile service, even when we're starting normally
2. Switch Profile opens the profile selection dialog with a flag
3. If the dialog is not cancelled then it tries to restart using that profile

Comment 1

[[e-mail]]

Attachment: Proof of concept

This just shows how it would be possible to open the profile selection dialog.
More work on the dialog itself would be necessary.

I'd probably also want to port the fixes to the old profile dialog.

Comment 2

[Benjamin Smedberg]

nsIToolkitProfileService makes all kinds of assumptions about the nsIToolkitProfile objects it is passing around. If we're going to do this we should significantly harden it to ensure that the correct object is getting passed around (e.g. in nsToolkitProfileService::SetSelectedProfile). Also I don't particularly want to parse the profiles.ini file and set up a bunch of objects at every startup, so we'd need to lazy-load the service (perhaps by separating the factory and service objects).

I'm not sure that I want to share the UI: does it make more sense to seamonkey to ship its own profile-switching UI?

Comment 3

[[e-mail]]

Attachment: Backend patch

* Creates a separate nsToolkitProfileFactory object
* ToolkitProfileFactory returns the existing instance if any
* Profile service factory is registered during normal startup
* Static cast eliminated (looked unsafe but probably wasn't)

Comment 4

[[e-mail]]

Fix checked in.

I'll resolve this and do the UI in a separate bug.