390861 - bookmarks toolbar shortened by 1px (hovered item seems to overflow the toolbar)

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Daniel.S]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080309 Minefield/3.0a8pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080309 Minefield/3.0a8pre

After the landing of the Native Theme Rendering for Windows XP (bug 243078, bug 337771) the bookmarks toolbar was shortened by 1px. Now, when hovering an item on the toolbar the button-style-borders seem to overflow the toolbar and that doesn't look very good.

I'll attach a screenshot to explain:
I compared branch and trunk before and after Native Theme Rendering bugs landed.

From the image you can see that the bottom of the bookmarks toolbar has always been slightly darker on trunk than on branch (I guess it was implemented differently on trunk). So when hovering a bookmark item it seems like it doesn't fit on trunk.

This is only a small visual glitch (which nevertheless should be fixed) but when Native Theme Rendering landed the dark line on the bottom of the bookmarks toolbar vanished. This increased the visibility of this glitch.

I suggest to reintroduce the dark line (if possible) and make item-hovering fitting better visually.


Reproducible: Always




Trunk "Before" and "After" mean 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071405 Minefield/3.0a7pre ID:2007071405
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071504 Minefield/3.0a7pre ID:2007071504
respectively.

The only bugs that should have had influence on this are bug 243078 and bug 337771.

Comment 1

[Daniel.S]

Attachment: comparison of branch and trunk before and after

Comment 2

[Daniel.S]

Attachment: claryfication of what exactly is missing

Comment 3

[Simon Bünzli]

Attachment: comparison screenshot with Windows Explorer

If you look closely, you'll see that there's no such dark line beneath the last toolbar in native applications (as e.g. Windows Explorer). This screenshot shows magnified samples from (1) Firefox with the tab bar hidden, (2) Firefox with the tab bar shown and (3) Windows Explorer, aligned by the notable double-line at the bottom of the toolbars/toolbox.

Directly beneath that double-line follows (1) the content area, (2) the tab bar and (3) Explorer's listview including a 1px blue top border - i.e. in all three cases the toolbar is finished with the double-line. The darker line you're concerned about shouldn't have been there in the first place and was removed in bug 337771.

Comment 4

[Daniel.S]

Still, there's the not so good-looking part of hovered items. XP doesn't work around this well in Windows Explorer (though they do it right on the navigation bar). I guess it won't be fixed then?
Sorry for bugspam.