Created attachment 275206 [details] [diff] [review] fix for link to graph bug When linking to a graph that has no data in the previous 30 days the graph server throws an exception. This patch correctly graphs a link that refers to data outside of the last 30 day window. Now it forces the collection of all data for a given data set - not the ideal solution but certainly workable for now. This should be re-examined when looking at the "all data/last x days" radio buttons - which should become "all data/provided date range" to make sense with the link to graph function. Also, adds a loading/graphing/etc status message. This is to reassure the end user that the graph server is actually doing something when drawing a graph is attempted. This status message has been present for dgraph.html for a while, so this is simply adding it to graph.html.
Attachment #275206 - Flags: review?(vladimir)
Attachment #275206 - Flags: review?(vladimir) → review+
Checking in graph.html; /cvsroot/mozilla/webtools/new-graph/graph.html,v <-- graph.html new revision: 1.13; previous revision: 1.12 done Checking in js/GraphCanvas.js; /cvsroot/mozilla/webtools/new-graph/js/GraphCanvas.js,v <-- GraphCanvas.js new revision: 1.7; previous revision: 1.6 done Checking in js/GraphFormModule.js; /cvsroot/mozilla/webtools/new-graph/js/GraphFormModule.js,v <-- GraphFormModule.js new revision: 1.6; previous revision: 1.5 done Checking in js/graph.js; /cvsroot/mozilla/webtools/new-graph/js/graph.js,v <-- graph.js new revision: 1.14; previous revision: 1.13 done
Assignee: nobody → anodelman
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.