390887 - tab drag and drop breaks tab box resizing

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[mcdavis941 (sporadically reading bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080309 Minefield/3.0a8pre

When working correctly, you can resize to decrease width of main browser window and the tab box will resize to keep the tab scroll arrows visible on both ends of the tab box.  However, after you drag and drop a tab, resizing to decrease width of main browser window only works until the dropped tab is at the right edge of the tab box, after which the tab box width will no longer decrease (instead, the right-side tab scroll arrow overflows off the right side of the window).

Reproducible: Always

Steps to Reproduce:
1. Configure Firefox to reopen tabs on restart.
2. Open five tabs.  They can hold anything or nothing.
3. Close Firefox.
4. Reopen Firefox.  All five tabs should still be present.
5. Resize window width both narrower and wider to demonstrate proper resizing of the tab box, including presence of tab scroll arrows.
6. Drag and drop the last tab to make it be the third tab.
7.  Resize window narrower.  This should demonstrate proper tab box resizing until the third tab is at the right edge of the tab box, after which the tab box improperly declines to get any more narrow, no matter how narrow you make the window.

Comment 1

[Ria Klaassen (not reading all bugmail)]

This is a recent regression; caused by bug 338302.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is happening because the tab drop indicator is now always present as far as layout is concerned (since it's just hidden rather than destroyed), and prevents the tabstrip from shrinking. I think the best way to fix this would be to just fix bug 390979 and use "collapsed" instead of toggling visibility.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[Asaf Romano (gone)]

Comment on attachment 275911 [details] [diff] [review]
patch

r=mano

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/tabbrowser.xml 	1.235

Comment 6

[Tony Chung [:tchung]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042304 Minefield/3.0pre

Reopening bug on mac osx, cause resizing the window clips the last tab.   See bug 430605.  

Comment 7

[:Gavin Sharp [email: [e-mail]]]

That bug doesn't look related to this one, sorry if I misled you on IRC.

Comment 8

[Hasham]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008060306 Minefield/3.0pre

Tried this in RC2 and nightly on XP and this is no longer a problem. The screen resizes properly.