390916 - Make fxdbug-linux-tbox turn orange if RLk is nonzero

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P3)

Description

[Jesse Ruderman]

RLk is zero on fxdbug-linux-tbox for the first time ever (see http://dbaron.org/log/2007-08#e20070804a).  To help it stay that way, I think we should make the tinderbox turn orange if RLk is nonzero.

Comment 1

[Jeff Walden [:Waldo]]

Given RLk's finickiness, perhaps we should make the exact amount of leakage a tinderbox preference?  We could set it to whatever the current value is on each of them, then, and not have to wait to drop the currently-8B RLk on fxdbug-linux-tbox back to 0B.  This would also allow us to set a limit on the Mac tinderbox, which recently had its RLk dropped to 12B.

Comment 2

[Jesse Ruderman]

Mac is now at 0B :)

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: first shot, untested, etc.

hey coop, what do you think of this approach for returning "testfailed" if RLk is above a certain threshold on leak tinderboxes?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You probably want the default to be something other than 0 (can it be infinite?), and then we can enable it for those tinderboxes where we want it.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

On second thoughts, maybe a default of 0 is good... but you should probably make the case where it's failing print an explanatory message to the log so it's clear why the tinderbox is orange.

Comment 6

[Chris Cooper [:coop] (he/him)]

Comment on attachment 283619 [details] [diff] [review]
first shot, untested, etc.

Looks like it should do the trick.

Comment 7

[Robert Helmer [:rhelmer]]

Attachment: print reason for test failure to log

David, is this what you had in mind?

Comment 8

[Jesse Ruderman]

"Number of leaks" should be something like "Number of bytes leaked".

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to comment #8)
> "Number of leaks" should be something like "Number of bytes leaked".
> 

Good point, maybe something more like:

print_log "Leak Test Failed: Number of bytes leaked ($leaks) is greater than LeakFailureThreshold ($Settings::LeakFailureThreshold)";

I'll do some testing on this patch and resubmit. If anyone wants to propose any changes in the meantime, please do and I'll include it in the next version.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283683 [details] [diff] [review]
print reason for test failure to log

Looks good to me, especially with the new wording from comment 9.  r=dbaron

Comment 11

[(not currently active) Ted Mielczarek]

FWIW, you'll get a little more use out of this if you stick an "Error: " in there, so the tinderbox error parser will show it in the brief log:
http://lxr.mozilla.org/mozilla/source/webtools/tinderbox/ep_unix.pl#47

Comment 12

[Robert Helmer [:rhelmer]]

I don't have time to land this and watch for bustage right now, returning to the build pool in the meantime in case someone else does.

Comment 13

[(not currently active) Ted Mielczarek]

I checked this in for you, but I stuck an Error: at the beginning.  This might break balsa on the 1.8 branch, and it might break nye on the SeaMonkey tree, but we can probably fix them via tinder-config.  I'll watch and see.

Comment 14

[(not currently active) Ted Mielczarek]

FWIW, this works:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8/1193277180.1193278532.6501.gz

Comment 15

[(not currently active) Ted Mielczarek]

Attachment: set leak threshold on balsa

I checked this in to MOZILLA_1_8_BRANCH_test_mem to fix balsa.  balsa leaks a lot.  It also seems reasonable that maybe the 1.8 branch tinderboxes shouldn't be running the trunk tinderbox code, but that's probably just more crap to deal with.

Comment 16

[(not currently active) Ted Mielczarek]

Conveniently balsa has gone AWOL, I filed bug 401051 on that.

Comment 17

[Robert Helmer [:rhelmer]]

Comment on attachment 286109 [details] [diff] [review]
set leak threshold on balsa

r+ with trailing semicolon as per bug 401051#c2 :)