Last Comment Bug 391019 - commandline for external protocol handler is mishandled
: commandline for external protocol handler is mishandled
: fixed1.8.1.12
Product: Core Graveyard
Classification: Graveyard
Component: File Handling (show other bugs)
: unspecified
: x86 OS/2
: -- normal (vote)
: ---
Assigned To: Peter Weilbacher
Depends on:
  Show dependency treegraph
Reported: 2007-08-05 12:43 PDT by Rich Walsh
Modified: 2016-06-22 12:16 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

don't append URL if already replaced full URL (2.46 KB, patch)
2007-12-26 10:24 PST, Peter Weilbacher
mozilla: review+
Details | Diff | Splinter Review

Description Rich Walsh 2007-08-05 12:43:59 PDT
Depending on where an external protocol handler is specified, the target app will receive different commandline arguments.  The examples below use "mailto:" but the behavior described applies to all supported protocols.

If you use os2.ini->DefaultMailParameters, specifying either "-compose" or "-compose %url%" will produce the same commandline:
e.g. " -compose".
Using prefs.js->applications.mailto.parameters will produce different results. Entering just "-compose" results in the same commandline as above.  However, entering "-compose %url%" produces:
e.g. " -compose".
Comment 1 Peter Weilbacher 2007-12-26 10:24:15 PST
Created attachment 294574 [details] [diff] [review]
don't append URL if already replaced full URL

This should fix this. At least on the 1.8 branch where this feature still works. (I would check the same change into trunk but there this method was moved to nsMIMEInfoOS2 so I would patch nsMIMEInfoOS2.cpp instead when checking it in.)
Comment 2 Peter Weilbacher 2007-12-26 14:03:31 PST
Fix checked into trunk (uriloader/exthandler/os2/nsMIMEInfoOS2.cpp v1.11) and 1.8 branch (uriloader/exthandler/os2/nsOSHelperAppService.cpp v1.41.18.1).

Note You need to log in before you can comment on or make changes to this bug.