391130 - View->Apply Theme->Get New Themes doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

function getNewThemes()
{
  openTopWin(gBrandRegionBundle.getString("getNewThemesURL"));
}

We no longer keep the URL in that bundle. Instead the URL can be obtained by
formatting the extensions.getNewThemesURL preference using the URL formatter
in a similar way to the way goReleaseNotes method in utilityOverlay.xul does.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: Get more themes URL using URL formatter

The pref is now called extensions.getMoreThemesURL.

Comment 2

[Mark Banner (:standard8)]

Looking at MXR can't gBrandRegionBundle be removed as a result of this change?

http://mxr.mozilla.org/seamonkey/search?string=gBrandRegionBundle

That would also also allow the stringbundle bundle_brand_region to be removed from inclusion the XUL:

http://mxr.mozilla.org/seamonkey/search?string=bundle_brand_region&find=%2Fsuite&findi=&filter=&tree=seamonkey

Comment 3

[[e-mail]]

(In reply to comment #2)
>Looking at MXR can't gBrandRegionBundle be removed as a result of this change?
We should absolutely do this as part of this bug.

Comment 4

[Bruno 'Aqualon' Escherl]

Attachment: Use URL formatter and remove gBrandRegionBundle

Comment 5

[Bruno 'Aqualon' Escherl]

Attachment: Patch v3

Only remove things, that should be removed... thx Neil for spotting that line.

Comment 6

[Robert Kaiser]

Checked in, thanks for working on this!

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/200708081818 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

I used to get
{{
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle :: getString :: line 17"  data: no]
}}
which is gone and the URI is loaded, now.

V.Fixed.