391147 - hunspell doesn't build with msvc7.1 (no support for variadic macros, "unexpected in macro formal parameter list")

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

http://lxr.mozilla.org/seamonkey/source/extensions/spellcheck/hunspell/src/atypes.hxx#65

msvc7.1 barfs on that line, because it doesn't support variadic macros.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

msvc7.1 isn't officially supported on the trunk, but many people still use it. It'd be nice if we could at least workaround this issue, if not fix it (and ideally upstream the fix to avoid maintenance hassles).

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Might I suggest asking Nemeth to review it too?

Comment 4

[Németh László]

OOps, variadic macro is only C99 standard, not C++:
http://en.wikipedia.org/wiki/Variadic_macro.

I will use this nice patch in next Hunspell, but without variable names (unused variable names cause warnings in OOo build environment), if it is ok for MSVC:

#ifndef HUNSPELL_WARNING
#ifdef HUNSPELL_WARNING_ON
#define HUNSPELL_WARNING fprintf
#define WARNVAR warnvar
#else
static inline void HUNSPELL_WARNING(FILE *, const char *, ...) {}
#define WARNVAR
#endif
#endif

Thanks, Laci

Comment 5

[Robert Longson [:longsonr]]

Attachment: address review comments

I've removed the variable names as suggested but you need #define WARNVAR warnvar rather than #define WARNVAR otherwise the code does not compile.

Comment 6

[Robert Longson [:longsonr]]

Attachment: #define should be inside outer #endif

Comment 7

[Stuart Parmenter]

scott: can you please r+ this and get it in to the tree?

Comment 8

[Scott MacGregor]

Comment on attachment 275798 [details] [diff] [review]
#define should be inside outer #endif

thanks for the patch! I'll check this in right now.

Comment 9

[Scott MacGregor]

I had to back this out, the tree is closed.

Comment 10

[[e-mail]]

(In reply to comment #5)
>I've removed the variable names as suggested but you need #define WARNVAR
>warnvar rather than #define WARNVAR otherwise the code does not compile.
Or you could just remove the #define - WARNVAR is a perfectly legal name ;-)

Comment 11

[Robert Longson [:longsonr]]

checked in.