391261 - No windows media player invoked anymore with this testcase

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, normally I get to see the windows media player invoked with it, showing a short movie.
But in current trunk build, this doesn't work anymore. It worked in yesterday's trunk build.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-08-06+04&maxdate=2007-08-07+09&cvsroot=%2Fcvsroot
Regression from bug 364235 or perhaps more likely, bug 390385.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

OK, can you give some more details, like OS, version of WMP, version of the plugin?

this does work for me on winxp with WMP 11.

Comment 2

[Martijn Wargers (dead)]

I'm using WMP 10 on windowsXP.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

do you have a debug build? if so, could you make a log with NSPR_LOG_MODULES=objlc:5,Plugin:5,PluginNPP:5,PluginNPN:5

Comment 4

[Martijn Wargers (dead)]

Attachment: nsprlog

Sorry, my debug build is too old for this 1 day old regression.
It seems like regular builds also give (useful?) data with this option. Maybe this is what you need?

Comment 5

[Martijn Wargers (dead)]

Attachment: nsprlog

Sorry, I attached the wrong kind of log, this one is with the correct settings, with: set NSPR_LOG_MODULES=objlc:5,Plugin:5,PluginNPP:5,PluginNPN:5

Comment 6

[Martijn Wargers (dead)]

Attachment: nsprlog

Ok, this is now an nsprlog from my updated debug build.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

this looks ok....

but the warning near the end looks suspicious. Could you try applying the patch in bug 381812 and see whether that helps?

Comment 8

[Martijn Wargers (dead)]

I applied the patch from bug 381812 and rebuilt my tree, and I can still see this bug afterwards.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: experimental patch

Martijn, could you see if this patch fixes the issue?

(it's a hack... not for checkin, just for experimenting)

Comment 10

[Martijn Wargers (dead)]

Yes, that experimental patch fixes the issue for me.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 12

[Boris Zbarsky [:bzbarsky]]

So why does this work?  Document on the second CallSetWindow why it's needed?

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

like this?
  // WMP10 needs an additional SetWindow call here (bug 391261)

I don't know exactly why it's needed, but apparently it is...

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 277129 [details] [diff] [review]
patch

If that's the best we can do, then yes... :(

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsObjectFrame.cpp;
/cvsroot/mozilla/layout/generic/nsObjectFrame.cpp,v  <--  nsObjectFrame.cpp
new revision: 1.613; previous revision: 1.612
done
Checking in nsObjectFrame.h;
/cvsroot/mozilla/layout/generic/nsObjectFrame.h,v  <--  nsObjectFrame.h
new revision: 1.70; previous revision: 1.69
done

Comment 16

[Martijn Wargers (dead)]

Thanks, it's working fine now, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082111 Minefield/3.0a8pre