Closed
Bug 391506
Opened 17 years ago
Closed 17 years ago
Remove custom calUtils.js from gdata provider
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Fallen, Assigned: Fallen)
Details
(Whiteboard: [gdata-0.3])
Attachments
(2 files)
14.29 KB,
patch
|
dbo
:
review+
|
Details | Diff | Splinter Review |
767 bytes,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
To make it easier to use new features of calUtils, I want to just load it from chrome://calendar/content/calUtils.js. This might cause problems with older versions of sunbird/lightning, but as long as we are careful when creating new versions between calendar releases, thats just fine.
Attachment #275957 -
Flags: review?(daniel.boelzle)
Comment 1•17 years ago
|
||
Comment on attachment 275957 [details] [diff] [review] get rid of calUtils.js si, r=dbo.
Attachment #275957 -
Flags: review?(daniel.boelzle) → review+
Assignee | ||
Comment 2•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Whiteboard: [gdata-0.2.2]
Comment 3•17 years ago
|
||
Philipp, your calUtils.js is empty now, but hasn't been removed from CVS.
Assignee | ||
Comment 4•17 years ago
|
||
Thanks Martin, forgot about that. cvs rm'd them now.
Comment 5•17 years ago
|
||
Shouldn't it say 'dump("Error while loading calUtils.js\n");' in Line 105? 102 try { 103 loader.loadSubScript("chrome://calendar/content/calUtils.js", null); 104 } catch (e) { 105 dump("Error while loading " + scriptUri.spec + "\n"); 106 throw e; 107 }
Assignee | ||
Comment 6•17 years ago
|
||
Ah yes, it should. Care to whip up a patch for that?
Comment 7•17 years ago
|
||
"C:\Programme\GnuWin32\bin>diff -pu8 C:\calGoogleCalendarModule.orig.js C:\calGoogleCalendarModule.js > C:\calGoogleCalendarModule.js.patch" against http://lxr.mozilla.org/mozilla/source/calendar/providers/gdata/components/calGoogleCalendarModule.js from 2007-09-19.
Attachment #281533 -
Flags: review?(philipp)
Assignee | ||
Comment 8•17 years ago
|
||
Comment on attachment 281533 [details] [diff] [review] Fixed message if failing to load calUtils.js Looks good, checking in on HEAD and MOZILLA_1_8_BRANCH -> (STAYS) FIXED
Attachment #281533 -
Flags: review?(philipp) → review+
Assignee | ||
Updated•17 years ago
|
Whiteboard: [gdata-0.2.2] → [gdata-0.3]
You need to log in
before you can comment on or make changes to this bug.
Description
•