Closed Bug 391506 Opened 17 years ago Closed 17 years ago

Remove custom calUtils.js from gdata provider

Categories

(Calendar :: Provider: GData, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

(Whiteboard: [gdata-0.3])

Attachments

(2 files)

To make it easier to use new features of calUtils, I want to just load it from chrome://calendar/content/calUtils.js. This might cause problems with older versions of sunbird/lightning, but as long as we are careful when creating new versions between calendar releases, thats just fine.
Attachment #275957 - Flags: review?(daniel.boelzle)
Comment on attachment 275957 [details] [diff] [review]
get rid of calUtils.js

si, r=dbo.
Attachment #275957 - Flags: review?(daniel.boelzle) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [gdata-0.2.2]
Philipp, your calUtils.js is empty now, but hasn't been removed from CVS.
Thanks Martin, forgot about that. cvs rm'd them now.
Shouldn't it say 'dump("Error while loading calUtils.js\n");' in Line 105?

102         try {
103             loader.loadSubScript("chrome://calendar/content/calUtils.js", null);
104         } catch (e) {
105             dump("Error while loading " + scriptUri.spec + "\n");
106             throw e;
107         }
Ah yes, it should. Care to whip up a patch for that?
"C:\Programme\GnuWin32\bin>diff -pu8 C:\calGoogleCalendarModule.orig.js C:\calGoogleCalendarModule.js > C:\calGoogleCalendarModule.js.patch" against http://lxr.mozilla.org/mozilla/source/calendar/providers/gdata/components/calGoogleCalendarModule.js from 2007-09-19.
Attachment #281533 - Flags: review?(philipp)
Comment on attachment 281533 [details] [diff] [review]
Fixed message if failing to load calUtils.js

Looks good, checking in on HEAD and MOZILLA_1_8_BRANCH

-> (STAYS) FIXED
Attachment #281533 - Flags: review?(philipp) → review+
Whiteboard: [gdata-0.2.2] → [gdata-0.3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: