391506 - Remove custom calUtils.js from gdata provider

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: get rid of calUtils.js

To make it easier to use new features of calUtils, I want to just load it from chrome://calendar/content/calUtils.js. This might cause problems with older versions of sunbird/lightning, but as long as we are careful when creating new versions between calendar releases, thats just fine.

Comment 1

[Daniel Boelzle [:dbo]]

Comment on attachment 275957 [details] [diff] [review]
get rid of calUtils.js

si, r=dbo.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED.

Comment 3

[Martin Schröder [:mschroeder]]

Philipp, your calUtils.js is empty now, but hasn't been removed from CVS.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Thanks Martin, forgot about that. cvs rm'd them now.

Comment 5

[Ingo Müller]

Shouldn't it say 'dump("Error while loading calUtils.js\n");' in Line 105?

102         try {
103             loader.loadSubScript("chrome://calendar/content/calUtils.js", null);
104         } catch (e) {
105             dump("Error while loading " + scriptUri.spec + "\n");
106             throw e;
107         }

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Ah yes, it should. Care to whip up a patch for that?

Comment 7

[Ingo Müller]

Attachment: Fixed message if failing to load calUtils.js

"C:\Programme\GnuWin32\bin>diff -pu8 C:\calGoogleCalendarModule.orig.js C:\calGoogleCalendarModule.js > C:\calGoogleCalendarModule.js.patch" against http://lxr.mozilla.org/mozilla/source/calendar/providers/gdata/components/calGoogleCalendarModule.js from 2007-09-19.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 281533 [details] [diff] [review]
Fixed message if failing to load calUtils.js

Looks good, checking in on HEAD and MOZILLA_1_8_BRANCH

-> (STAYS) FIXED