391562 - Pass aExtraState as nsnull to GetFinalState() if not needed

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a caller doesn't need the extra states, it can call GetFinalState() with a 2nd argument of nsnull. This is more optimal.

Looking through the GetFinalState() callers there are a few obvious ones to fix.

Comment 1

[alexander :surkov (:asurkov)]

I didn't catch the bug issue. The summary says to make optional second argument but it's interface method, how we can do it.

> When a caller doesn't need the extra states, it can call GetFinalState() with a
> 2nd argument of nsnull. This is more optimal.

But this is presented behaviour I think.

Comment 2

[Aaron Leventhal]

> But this is presented behaviour I think.
Not sure what that means.

We can pass aExtraState as null.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> > But this is presented behaviour I think.
> Not sure what that means.
> 
> We can pass aExtraState as null.
> 

Right, we can and we do. Can you point a wrong code we shoudl fix?

Comment 4

[Aaron Leventhal]

One example was here:
http://lxr.mozilla.org/seamonkey/source/accessible/src/msaa/nsAccessibleWrap.cpp#502

I also saw that we could sometimes pass in null where we call it from nsAccessibleEventData.cpp.

After that I stopped looking, because it's not important for this release.

Comment 5

[alexander :surkov (:asurkov)]

Ah, I thought you talking about ability to pass nsnull! But you are talking about to pass nsnull where extraState is not needed.

Comment 6

[Aaron Leventhal]

Attachment: Pass null for extraState in 4 places that we don't need it

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 278175 [details] [diff] [review]
Pass null for extraState in 4 places that we don't need it

It's not important cleanup in the light of mergin state and extra state, though it's nice to have I guess for now :)

Comment 8

[Aaron Leventhal]

Comment on attachment 278175 [details] [diff] [review]
Pass null for extraState in 4 places that we don't need it

It avoids some extra work on every node. Since many ATs walk the entire tree on page load, that can be a lot of savings.

Also, low risk.