391592 - IA2 states exposed incorrectly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

The IA2-specific states are not at all exposed correctly.

Comment 1

[Aaron Leventhal]

Attachment: 1) Remove else's from if block, 2) Report 0 extended states

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 276039 [details] [diff] [review]
1) Remove else's from if block, 2) Report 0 extended states

r=me, though I'm not sure about NS_OK for those methods which aren't implemented. Why shouldn't we fail?

Comment 3

[Aaron Leventhal]

We shouldn't fail because there are in fact 0 of those extended states for that object at this time. Returning the fact that we know that is better than saying we don't know.

Comment 4

[Aaron Leventhal]

Thinking about it again, I guess I see how your point can be argued. I can still return E_NOIMPL there as long as we clear out the out param before we return. That part isn't a big deal to change.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> Thinking about it again, I guess I see how your point can be argued. I can
> still return E_NOIMPL there as long as we clear out the out param before we
> return. That part isn't a big deal to change.
> 

That would be fine.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381