391621 - Remove unused trimmed-space counting

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

In bug 385719 I removed Metrics::mClusterCount, without noticing that it was still used by nsTextFrameThebes::Reflow to compute the "number of letters" justification weight. To fix the bustage I just replaced usage of mClusterCount with charsFit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/generic&command=DIFF_FRAMESET&file=nsTextFrameThebes.cpp&rev1=3.59&rev2=3.60&root=/cvsroot
It's OK to count UTF16 codepoints instead of clusters because these are just weights and don't have to be exact.

This obviates the need for the loop above those lines that updates mClusterCount to include spaces trimmed off the end of the line. So, this patch removes that loop. (Including trimmed characters in the "letter count" was probably always a mistake, really.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 276065 [details] [diff] [review]
fix

a1.9=dbaron

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in