391662 - Google provider has problems with japanese text

Status: VERIFIED DUPLICATE of bug 388735

(Calendar :: Provider: GData, defect)

Description

[ashley smart]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: version 2.0.0.6 (20070728), Lightning 0.5, provider 0.2.1

If the google calander is set to be read in japanese or you add japanese text to the subject, the time of the meeting seems to be shifted by a consistant amount generally 1 hour before the time that is was scheduled.

Reproducible: Always

Steps to Reproduce:
1.switch googles calender interface to Japaneses (日本語)
2.create a new event on from Thunderbird 2.0.0.6 with version 0.5 lightning
3.observed the time shift
Actual Results:  
time is offset buy about 1hr...

Expected Results:  
no time offest

Comment 1

[Stefan Sitter [:ssitter]]

Where do you see the time shift? In the New Event dialog? In the Lightning calendar view? In the Google Calendar web interface? After creating the event? After reloading the calendar from the server? ...

Maybe you can clarify the "or you add japanese text to the subject" too: You have switched Google Calendar to non-Japaneses interface, e.g. English. In Lightning you create an event with English characters only and the time is correct. You create a second event but with Japanese characters and now the time is wrong.

Personally I don't think that switching the language has an effect on the events created. Maybe switching the Google Calendar interface language switches the timezones too? You could check the timezone setting in your OS, in Lightning and in Google Calendar. Bug 337191 describes a similar issue if the timezone of your Operating System and the timezone configured in Lightning differ.

Comment 2

[ashley smart]

i see it on the google cal.. once i click to submit it, it goes away for a bit and then the task appears, the bug happens after clicking ok and before the task appearing on the cal. Once its visible the times are all changed for what i put in the new event dialog. 

the same bug can happen 2 ways.. 
1) if write every thing in english in the new event dialog, but my google calender is in japanese then the bug SOMETIMES happens.
2) if my google calender is in English then when i make a new event and enter a Japanese subject or place then the bug SOMETIMES happens.

timezone setting for my desktop is
OS is +5:30 chennai, kolkata, mumbai, new deli
Lightning is Asia/Calcutta 
Google Calendar is +9:00 東京 (tokyo)
(sorry i travel way to much...to keep switching it)

its a definitely possible that its related to Bug 337191 BUT there are some key diffs the time change is RANDOM and the fact that it only happens in if use japanese text doesn't make sense against that bug.. 

> Personally I don't think that switching the language has an effect on the
> events created. 
You'd might be surprised that learn that Japanese characters are can be 16bits width(depending on the chars anchor codes) so many ppl code under the assumption that its ALWAYS 8bits.. this causes all sorts of strange bugs to appear especially in data parsers, and input windows. I assume data is being feed into google cal by a after some slight modification right.. 

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

For me to sufficiently reproduce this, it would be nice if you could either attach an ICS file that contains the exact set of characters that cause failure, or tell me how to input a such character that causes problems.

As long as the Japanese characters can be depicted with UTF8, there should be no problems but Id be glad to test this.

Comment 4

[ashley smart]

ok i just aligned all my timezones (OS,ligthning,google cal) and then switched the google cal to english and made an event with the following subject.. 

てすと

it produced a -1hr time change...

Comment 5

[ashley smart]

if a cut and paste doesnt work we might need to set some stuff in your regional settings.. ie set the the default unicode for your winXP to japanese... also it produces a -2hr time change sorry just bad maths..  

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

I could not reproduce this error using the string てすと. I changed my system locale to Japanese for the current user. I think this problem has to do with some timezone settings or view settings. Anyway, we need a clear set of steps to reproduce this. To find them, please use a new profile and try to produce the error. Then clean the profile and try to do the exact same thing. If that works, we can help some more.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Also, please test with non-gdata calendars to see if this is gdata specific or not.

Comment 8

[ashley smart]

ok i have verified it... the problem still exists... 

1) I have created a clean profile, using -profilemanager boot option with "Thunderbird 2.0.0.6(20070604)" with ONLY "Lightning 0.5" and "Provider for Google Calendar 0.2.1" installed. With ALL timezones (Google, Lightning and Windows) synced before the profile was created. Therefore it NOT a timezone problem. Therefore it is NOT a View/Setting Problem

2) I then create an event for today at 12 noon on the GOOGLE calender with the text てすと, and the result was google calender receiving and event for 11AM. Result is INCORRECT.

3) I then create and event for today at 12 noon on the LOCAL calender with the text てすと, and the result was the local calender receiving and event for 12noon. Result is CORRECT.

how do we progress.. the bug is 100% reproducible here.. 

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

I still could not reproduce. What timezone do you have set? Try to enable calendar.debug.log in the advanced config editor (i.e set it to true), there should be a lot of output on the error console. Either attach as file or show me all lines that contain something date related or have a <gd:when> tag.

Comment 10

[ashley smart]

dont worry i have located the bug in the code for u...  yes it is the timezone..  set the timezone as follows...
OS is +5:30 chennai, kolkata, mumbai, new deli 
Lightning as Asia/Calcutta   (which is +5:30)

open the file calGoogleUtils.js and locate the function toRFC3339... and add the dump lines to starting at line 324

//ADD THIS CODE 
dump("timezoneOffset " + aDateTime.timezoneOffset + "\n");
dump("tzoffset_hr " + tzoffset_hr + "\n"); 
dump("tzoffset_mn " + tzoffset_mn + "\n"); 

so that the code looks like this

//...SNIP...
function toRFC3339(aDateTime) {

    if (!aDateTime || !aDateTime.isValid) {
        return "";
    }

    var tzoffset_hr = (aDateTime.timezoneOffset / 3600).toFixed(0);

    var tzoffset_mn = ((aDateTime.timezoneOffset / 3600).toFixed(2) -
                       tzoffset_hr) * 60;

    //ADD THIS CODE 
    dump("tzoffset_hr " + tzoffset_hr + "\n"); 
    dump("tzoffset_mn " + tzoffset_mn + "\n"); 

//...SNIP...

Then run thunderbird with -console option... and create the event as described above...  watch the console output and not that the result is

timezoneOffset 19800 
tzoffset_hr 6 
tzoffset_mn -30

first the -30 minutes...  well its negative.. that would be a problem dont u think... but the bug is the 6! when it should be 5... hence my new events are 1hr behind!...  the BUG is caused by the use of toFixed.. 

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Aha, that sounds much better. In that case this is a duplicate of bug 388735, which has been fixed and will be contained in the upcoming release. Thanks for taking the time to find out why!