391673 - Event dialog: Reminder List contains too many items

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Christian Jansen]

The current Reminder contains too many items:
It should be reduced to a readable number of items:

No Reminder
-----------------
5 min before 
10 min before 
30 min before
 ------------------
1 hour before
2 hours before
15 hours before
 -------------------
1 day before
2 days before
7 days before
--------------------
Edit Custom Reminders...

Comment 1

[Stefan Sitter [:ssitter]]

What would be a readable (and useful) number of items?

  15 minutes before
  1  hour befor
  1  day before
  Custom Reminder...

Comment 2

[Stefan Sitter [:ssitter]]

What about making the default reminder values configurable? 

Instead of hard-coding the default reminders into the xul file there could be e.g. a preference containing as comma separated list of default values. For example "15, 60, 1440". Upon opening the dialog this would be parsed to "15 minutes", "1 hour" and "1 day". 

This would make it easier to change the default set of reminders or to customize the default reminders to the users requirements e.g. via about:config or extension.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops, sorry, my bad, returning to the right component, awfully sorry about stomping your target milestone, please send hatemail to this address :(

Comment 4

[Pete Riley]

> The current Reminder contains too many items

> What about making the default reminder values configurable?
> e.g. via about:config or extension

Why not combine your ideas and make the list of available reminders in the dropdown a mirror of the list in the Custom dialog?  This way it would be easy for us to customize the choices in the dropdown to our own needs and we wouldn't need to open the Custom dialog as often.

In this case I would change the word in the dropdown from "Custom..." to "Customize..." to emphasize that the purpose would be to customize the values in the dropdown.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to comment #4)
> Why not combine your ideas and make the list of available reminders in the
> dropdown a mirror of the list in the Custom dialog?  This way it would be easy
> for us to customize the choices in the dropdown to our own needs and we
> wouldn't need to open the Custom dialog as often.
Given the "Custom" option has changed to now show multiple reminders, I think we should leave this to an extension.

It would make a very nice extension. I might actually do this soon.


Do we want to further shorten the list? I'd suggest the following:



No Reminder
-----------------
0 min before 
5 min before
15 min before 
30 min before
 ------------------
1 hour before
2 hours before
12 hours before
 -------------------
1 day before
2 days before
1 week before
--------------------
Edit Custom Reminders...



(Brennan, I hope its ok I reassign this bug to myself?)

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I've just uploaded the addon previously promised to
https://addons.mozilla.org/en-US/thunderbird/addon/97408/

Comment 7

[Pete Riley]

Thanks Philipp, the extension to edit the list of custom alarms works like a charm.  The only problem is that the rows in the list don't highlight when I click them (but the separator rows do).  I'm referring to "Tools > Addons > Custom Alarms > Options".  I'm using WinXP ("Classic Theme" if it matters) and TB 3.0.1 official.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pete, likely a windows-only issue. I'll see what I can do!

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 437808 [details] [diff] [review]
Fix - v1

This patch takes care, based on my above suggestion in comment 5.

Requesting ui-review to make sure its the right set.

Comment 11

[Markus Adrario [:Taraman]]

Comment on attachment 437808 [details] [diff] [review]
Fix - v1

patch looks good and works as expected.

r=markus

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 437808 [details] [diff] [review]
Fix - v1

looks good

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/ccabde3874e3>
-> FIXED

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/09b9bcff234c>
-> FIXED