Closed
Bug 391683
Opened 17 years ago
Closed 17 years ago
AppleScript: Tabs can't handle "close" command
Categories
(Camino Graveyard :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peeja, Assigned: peeja)
References
Details
(Keywords: fixed1.8.1.13)
Attachments
(1 file, 3 obsolete files)
3.07 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Browser window gets "close" support for free as a subclass of window, but the tab class knows nothing about closing. It should. More specifically,
> tell application "Camino" close tab 1 of browser window 1
should do just that, rather than raise an error.
Assignee | ||
Updated•17 years ago
|
Blocks: 382493
Comment 1•17 years ago
|
||
Peter, have you done any work on this? It's one of the few remaining AS bugs that we'd like to get to have a good amount of support.
Assignee | ||
Comment 2•17 years ago
|
||
As with bug 394821, expect progress soon. We regret the delay.
Assignee | ||
Comment 3•17 years ago
|
||
Adds a method to BrowserWrapper (tab) which closes the tab, and adds the relevant info to the sdef.
Unfortunately, bug 396263 would bitrot this patch, so the patch is built to land after that bug (which is currently ready to land itself).
Attachment #298045 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #298045 -
Flags: review? → review?(Jeff.Dlouhy)
Assignee | ||
Comment 4•17 years ago
|
||
Sorry, this one should patch fine. Ignore my previous comments.
Attachment #298045 -
Attachment is obsolete: true
Attachment #298048 -
Flags: review?(Jeff.Dlouhy)
Attachment #298045 -
Flags: review?(Jeff.Dlouhy)
Comment 5•17 years ago
|
||
Comment on attachment 298048 [details] [diff] [review]
Tab Close Support (Working Patch)
Seems to work as advertised. :-P
r=jeff
Attachment #298048 -
Flags: review?(Jeff.Dlouhy) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #298048 -
Flags: superreview?(stuart.morgan)
Comment 6•17 years ago
|
||
Comment on attachment 298048 [details] [diff] [review]
Tab Close Support (Working Patch)
>- BrowserWindow *window = (BrowserWindow *)[self getNativeWindow];
>+ BrowserWindow *window = (BrowserWindow *)[self nativeWindow];
Why are you changing from the branch method to the trunk method in a diff from branch? This will break objectSpecifier.
Assignee | ||
Comment 7•17 years ago
|
||
Eek, good catch Stuart. That's just an artifact of my naive cvs diff. This version should do; I've removed the rogue hunk. It wasn't easy. The ladies were crawling all over him.
Attachment #298048 -
Attachment is obsolete: true
Attachment #300640 -
Flags: superreview?(stuart.morgan)
Attachment #298048 -
Flags: superreview?(stuart.morgan)
Comment 8•17 years ago
|
||
Does closeTab: do what we want on the last tab in a window? I can't test at the moment, but I'm pretty sure the answer is no.
Assignee | ||
Comment 9•17 years ago
|
||
Now checks to see if we're the last tab, and closes the whole window if so. Also fixes a comment typo.
To check in on branch, replace nativeWindow with getNativeWindow.
Attachment #300640 -
Attachment is obsolete: true
Attachment #300914 -
Flags: superreview?(stuart.morgan)
Attachment #300640 -
Flags: superreview?(stuart.morgan)
Comment 10•17 years ago
|
||
Comment on attachment 300914 [details] [diff] [review]
No Tabless Windows (see #9 before branch checkin)
sr=smorgan
Attachment #300914 -
Flags: superreview?(stuart.morgan) → superreview+
Checked in on the trunk and the MOZILLA_1_8_BRANCH (with getNativeWindow) in advance of b3.
Note that you might want to update your tree so that the fix for bug 396263 appears in it ;) Luckily, the merge here was easy, and closing tabs is now fun and fully operational.
You need to log in
before you can comment on or make changes to this bug.
Description
•