391683 - AppleScript: Tabs can't handle "close" command

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Peter Jaros (:peeja)]

Browser window gets "close" support for free as a subclass of window, but the tab class knows nothing about closing.  It should.  More specifically,

> tell application "Camino" close tab 1 of browser window 1

should do just that, rather than raise an error.

Comment 1

[Samuel Sidler (old account; do not CC)]

Peter, have you done any work on this? It's one of the few remaining AS bugs that we'd like to get to have a good amount of support.

Comment 2

[Peter Jaros (:peeja)]

As with bug 394821, expect progress soon.  We regret the delay.

Comment 3

[Peter Jaros (:peeja)]

Attachment: Tab Close Support

Adds a method to BrowserWrapper (tab) which closes the tab, and adds the relevant info to the sdef.

Unfortunately, bug 396263 would bitrot this patch, so the patch is built to land after that bug (which is currently ready to land itself).

Comment 4

[Peter Jaros (:peeja)]

Attachment: Tab Close Support (Working Patch)

Sorry, this one should patch fine.  Ignore my previous comments.

Comment 5

[Jeff Dlouhy]

Comment on attachment 298048 [details] [diff] [review]
Tab Close Support (Working Patch)

Seems to work as advertised. :-P

r=jeff

Comment 6

[Stuart Morgan]

Comment on attachment 298048 [details] [diff] [review]
Tab Close Support (Working Patch)

>-  BrowserWindow *window = (BrowserWindow *)[self getNativeWindow];
>+  BrowserWindow *window = (BrowserWindow *)[self nativeWindow];

Why are you changing from the branch method to the trunk method in a diff from branch? This will break objectSpecifier.

Comment 7

[Peter Jaros (:peeja)]

Attachment: Same, minus mistake

Eek, good catch Stuart.  That's just an artifact of my naive cvs diff.  This version should do; I've removed the rogue hunk.  It wasn't easy.  The ladies were crawling all over him.

Comment 8

[Stuart Morgan]

Does closeTab: do what we want on the last tab in a window? I can't test at the moment, but I'm pretty sure the answer is no.

Comment 9

[Peter Jaros (:peeja)]

Attachment: No Tabless Windows (see #9 before branch checkin)

Now checks to see if we're the last tab, and closes the whole window if so.  Also fixes a comment typo.

To check in on branch, replace nativeWindow with getNativeWindow.

Comment 10

[Stuart Morgan]

Comment on attachment 300914 [details] [diff] [review]
No Tabless Windows (see #9 before branch checkin)

sr=smorgan

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and the MOZILLA_1_8_BRANCH (with getNativeWindow) in advance of b3.

Note that you might want to update your tree so that the fix for bug 396263 appears in it ;)  Luckily, the merge here was easy, and closing tabs is now fun and fully operational.