Closed Bug 391798 Opened 17 years ago Closed 17 years ago

add an UI ability to enable/disable accessibility views

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

Since we have a lot views for accessibility inspection and I think we don't need to keep them turned on by default then we need an ability to enable/disable it.
Attached patch patchSplinter Review
Assignee: vasiliy.potapenko → surkov.alexander
Status: NEW → ASSIGNED
Attachment #277914 - Flags: superreview?(neil)
Attachment #277914 - Flags: review?(comrade693+bmo)
Doesn't View->Show Accessible Nodes already turn off those panels?
(In reply to comment #2)
> Doesn't View->Show Accessible Nodes already turn off those panels?
> 

No, this option makes/unmakes bold accessible nodes in 'DOMNodes' view and enables/disabled accessible related views in right panel. But views for the left panel aren't depend on this option.

I added an option to enable/disable all accessible views and if they are disabled then it disables 'Show Accessible Nodes' option too.
Well I still fail to see why you need two options that do almost the same...
(In reply to comment #4)
> Well I still fail to see why you need two options that do almost the same...
> 

1. Disable completely accessibility support. Accessibility features are used only by those users who care about accessibility of his page or by accessibility developers. We should allow not to know about ally for the rest of users.

2. Show/hide accessible nodes inside DOMNodes view. I often inspect accessibility and I keep enabled the first option always. But sometimes I don't need to see accessibles objects in DOMNodes view. In that case I should be able to hide them because they marked bold and this draws away my attention.
OK, so how does bug 394253 affect this?
(In reply to comment #6)
> OK, so how does bug 394253 affect this?
> 

I need to update the patch to trunk.
But I still don't see the point of hiding the views...
(In reply to comment #8)
> But I still don't see the point of hiding the views...
> 

I think they make DOMi UI more complicated. I think users who don't want ally stuff shouldn't see those views. No?
(In reply to comment #9)
> I think they make DOMi UI more complicated. I think users who don't want ally
> stuff shouldn't see those views. No?
Well, there are a lot of viewers that I never use, but are still there.  I'm not sure if it will hurt us :/
Ok, if you both do not see usability of this then worksforme?
Attachment #277914 - Flags: superreview?(neil)
Comment on attachment 277914 [details] [diff] [review]
patch

I am indifferent on the resolution.
Attachment #277914 - Flags: review?(comrade693+bmo)
ok, wontfix then
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: