If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

add an UI ability to enable/disable accessibility views

RESOLVED WONTFIX

Status

Other Applications
DOM Inspector
RESOLVED WONTFIX
10 years ago
10 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Since we have a lot views for accessibility inspection and I think we don't need to keep them turned on by default then we need an ability to enable/disable it.
(Assignee)

Comment 1

10 years ago
Created attachment 277914 [details] [diff] [review]
patch
Assignee: vasiliy.potapenko → surkov.alexander
Status: NEW → ASSIGNED
Attachment #277914 - Flags: superreview?(neil)
Attachment #277914 - Flags: review?(comrade693+bmo)

Comment 2

10 years ago
Doesn't View->Show Accessible Nodes already turn off those panels?
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> Doesn't View->Show Accessible Nodes already turn off those panels?
> 

No, this option makes/unmakes bold accessible nodes in 'DOMNodes' view and enables/disabled accessible related views in right panel. But views for the left panel aren't depend on this option.

I added an option to enable/disable all accessible views and if they are disabled then it disables 'Show Accessible Nodes' option too.

Comment 4

10 years ago
Well I still fail to see why you need two options that do almost the same...
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
> Well I still fail to see why you need two options that do almost the same...
> 

1. Disable completely accessibility support. Accessibility features are used only by those users who care about accessibility of his page or by accessibility developers. We should allow not to know about ally for the rest of users.

2. Show/hide accessible nodes inside DOMNodes view. I often inspect accessibility and I keep enabled the first option always. But sometimes I don't need to see accessibles objects in DOMNodes view. In that case I should be able to hide them because they marked bold and this draws away my attention.

Comment 6

10 years ago
OK, so how does bug 394253 affect this?
(Assignee)

Comment 7

10 years ago
(In reply to comment #6)
> OK, so how does bug 394253 affect this?
> 

I need to update the patch to trunk.

Comment 8

10 years ago
But I still don't see the point of hiding the views...
(Assignee)

Comment 9

10 years ago
(In reply to comment #8)
> But I still don't see the point of hiding the views...
> 

I think they make DOMi UI more complicated. I think users who don't want ally stuff shouldn't see those views. No?
(In reply to comment #9)
> I think they make DOMi UI more complicated. I think users who don't want ally
> stuff shouldn't see those views. No?
Well, there are a lot of viewers that I never use, but are still there.  I'm not sure if it will hurt us :/
(Assignee)

Comment 11

10 years ago
Ok, if you both do not see usability of this then worksforme?

Updated

10 years ago
Attachment #277914 - Flags: superreview?(neil)
Comment on attachment 277914 [details] [diff] [review]
patch

I am indifferent on the resolution.
Attachment #277914 - Flags: review?(comrade693+bmo)
(Assignee)

Comment 13

10 years ago
ok, wontfix then
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.