391854 - [Proto] Task dialog: Cannot set Due date/time different from Start date/time

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070811 Calendar/0.7pre

[Proto] Task dialog: Cannot set Due date/time different from Start date/time

Steps to Reproduce:
1. Start Sunbird with a new clean profile
2. Select menu File -> New Task
3. Enable and set Start date/time
4. Enable and set Due date/time different from Start date/time

Actual Results:
It's not possible set Due date/time different from Start date/time. You can change the Due date/time to a different value but as soon as you move the focus to another input element or save the task the Due date is set back and is the same as the Start date.

Expected Results:
It should be possible to set the Due date/time different from Start date/time.

Comment 1

[Stefan Sitter [:ssitter]]

Allowing only zero-length tasks is a regression compared to our 0.5 release. Therefore I think this should be fixed before 0.7.

Comment 2

[Stefan Sitter [:ssitter]]

I tracked the issue down to the following location in sun-calendar-event-dialog.js: updateEndTime() calls updateDateTime(). But if the task has both entry date and due date it will always enter the first part of the if clause and assigns the entry date to the due date.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/prototypes/wcap/sun-calendar-event-dialog.js&rev=1.23&mark=2267-2283,2307-2322#2264

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: rev0 - proposed patch

Consider the case that both start and due date are set.

Comment 4

[Martin Schröder [:mschroeder]]

We decided on the QA chat this bug is a regression and the task dialog is not usable without this. -> blocks 0.7

Comment 5

[Michael Büttner (no reviews TFN)]

Comment on attachment 276698 [details] [diff] [review]
rev0 - proposed patch

Interestingly enough, I already came across this issue while I wrote the patch for Bug 351084. As I thought this other patch would land much earlier I decided to add the same code snippet as is now attached to this Bug. r=mickey.

Comment 6

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070829 Calendar/0.7pre