391857 - can't open file with doubleclick (new DM)

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081115 Minefield/3.0a8pre ID:2007081115

repro:
download a .zip
doubleclick on the icon/filename

result:
nada

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

This patch makes double-clicking perform the same action as the first button per the mockup docs.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 276350 [details] [diff] [review]
Patch

>+    switch (state) {
>+      case Ci.nsIDownloadManager.DOWNLOAD_FINISHED:
>+        gDownloadViewController.doCommand("cmd_open");
>+        break;
So, I don't quite like this because cmd_open is disabled when the file doesn't exist.  Instead of the switch statement, you could probably get away with iterating through these four commands and seeing which, if any, are enabled, and then execute it.  If none are enabled, just do nothing.

>+  gDownloadsView.addEventListener("dblclick", onDownloadDblClick, false);
Also, please add a comment above this line stating something like "Even Listeners".  This was in here before, but I had actually gutted them all out.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 276350 [details] [diff] [review]
Patch

er, nevermind that - just add the comment please.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/toolkit/mozapps/downloads/content/downloads.js 1.71

Comment 5

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081201 Minefield/3.0a8pre ID:2007081201

VERIFIED

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=3976

in-litmus+