391870 - Have the download manager store the referring uri when appropriate (and use it in the front end)

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007081115 Minefield/3.0a8pre ID:2007081115

1. Complete a download
2. Click on the Information button. You get a date and two buttons.
   The second button opens the dir the file downloaded to.
   The first button doesn't appear to do anything (it should open the file?)

So what should the first button do?

Comment 1

[Steve England [:stevee]]

Attachment: what should it do?

Comment 2

[Shawn Wilsher :sdwilsh]

Nothing right now - it will open the page where you got the download from.  I can't recall if I filed a follow-up bug for that yet.

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v1.0 moving nsIDownload

Moves nsIDownload as per biesi's request.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.1 moving nsIDownload & nsIProgressDialog

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.0 everything

r+sr=biesi for the bits not in toolkit.

Uploaded to buildbot try patch and I'll post a link to the builds with it shortly.

Comment 6

[Shawn Wilsher :sdwilsh]

OK, so v1.0 doesn't build on windows.  I'm trying a small fix now with the try patch server.

Mac build:
https://build.mozilla.org/tryserver-builds/[e-mail]
Linux build:
https://build.mozilla.org/tryserver-builds/[e-mail]2

Comment 7

[Shawn Wilsher :sdwilsh]

Attachment: v1.1 everything

Fixes bitrot, builds on windows.

Linux:
https://build.mozilla.org/tryserver-builds/[e-mail]2
Mac:
https://build.mozilla.org/tryserver-builds/[e-mail]
Windows:
https://build.mozilla.org/tryserver-builds/[e-mail]

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

you might want to try getting the docshell referrer property from the channel and using the nsIHttpChannel only if that failed
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsDocShell.cpp#8340

(you still need the httpchannel one to get "save link target as" to work right)

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 276658 [details] [diff] [review]
v1.1 everything

I'm unbitrotting and addressing biesi's comments (as well as a few optimizations)

Comment 10

[Shawn Wilsher :sdwilsh]

Attachment: v1.2 everything

Comment 11

[Shawn Wilsher :sdwilsh]

Attachment: v1.3 everything

Fixes comments on irc.

Comment 12

[Shawn Wilsher :sdwilsh]

Attachment: v1.4

Comment 13

[Asaf Romano (gone)]

Comment on attachment 277160 [details] [diff] [review]
v1.4

+  var uir;

init that to beltzner.

+  if (aDownload.hasAttribute("referrer"))
+    uri = aDownload.getAttribute("referrer");

r=mano otherwise.

Comment 14

[Shawn Wilsher :sdwilsh]

Attachment: v1.5 (checked in)

For checkin

Comment 15

[Shawn Wilsher :sdwilsh]

Not sure how both of us missed this :(

+      if (!mReferrer) {
         nsCOMPtr<nsIHttpChannel> chan = do_QueryInterface(aRequest);
         if (chan) {
           rv = chan->GetReferrer(getter_AddRefs(mReferrer));
           if (NS_FAILED(rv) )
             mReferrer = nsnull;
         }
+      }

Comment 16

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/public/Makefile.in;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/components/downloads/public/nsIDownload.idl;
new revision: 1.20; previous revision: 1.19
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.102; previous revision: 1.101
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.34; previous revision: 1.33
Checking in toolkit/components/downloads/test/schema_migration/test_migration_to_2.js;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/components/downloads/test/schema_migration/test_migration_to_3.js;
initial revision: 1.1
Checking in toolkit/components/downloads/test/schema_migration/v2.sqlite;
initial revision: 1.1
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
new revision: 1.23; previous revision: 1.22
Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.81; previous revision: 1.80
Checking in toolkit/mozapps/downloads/content/downloads.xul;
new revision: 1.28; previous revision: 1.27
Checking in embedding/components/ui/progressDlg/Makefile.in;
new revision: 1.6; previous revision: 1.5
Removing embedding/components/ui/progressDlg/nsIProgressDialog.idl;
new revision: delete; previous revision: 1.15
Checking in uriloader/base/Makefile.in;
new revision: 1.40; previous revision: 1.39
Removing uriloader/base/nsIDownload.idl;
new revision: delete; previous revision: 1.19
Checking in xpfe/components/download-manager/public/Makefile.in;
new revision: 1.4; previous revision: 1.3
Checking in xpfe/components/download-manager/public/nsIDownload.idl;
new revision: 1.3; previous revision: 1.2
Checking in widget/src/windows/nsDragService.cpp;
new revision: 1.56; previous revision: 1.55

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4568

in-litmus+

Only the implementation is verified, not the functionality.  I'm going to spin off a separate bug, because, according to the design docs at http://wiki.mozilla.org/User:Dmose:Fx-Docs:DownloadManager/User_Interface, 

"clicking the URL icon will open a browser on the URL, which is the URI up to the point where the file name started".

Currently, it does nothing, and lists the file, which it shouldn't (just the path URI).

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007081705 Minefield/3.0a8pre

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

I spun off bug 392697.

Comment 19

[Steffen Wilberg]

Shouldn't "referrer" be added to the columns that must be present when downgrading the database schema, so that we rebuild the table if we downgrade from a future version that doesn't contain the referrer column?
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.106&mark=309#299

Comment 20

[Shawn Wilsher :sdwilsh]

(In reply to comment #19)
> Shouldn't "referrer" be added to the columns that must be present when
> downgrading the database schema, so that we rebuild the table if we downgrade
> from a future version that doesn't contain the referrer column?
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp&rev=1.106&mark=309#299
Yes, good catch.

Comment 21

[Shawn Wilsher :sdwilsh]

Attachment: v1.5.1

Thanks for catching that!

Comment 22

[Asaf Romano (gone)]

Comment on attachment 277928 [details] [diff] [review]
v1.5.1

r=mano.

Comment 23

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.108; previous revision: 1.107