391915 - "ASSERTION: AtomImpl not thread-safe" within nsCacheMetaData::MetaElement::~MetaElement

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Jesse Ruderman]

Attachment: stack trace

Steps to reproduce:
1. Load http://www.atiz.com/snapter.html.
2. Wait a few seconds.

Result:
###!!! ASSERTION: AtomImpl not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /Users/jruderman/trunk/mozilla/xpcom/ds/nsAtomTable.cpp, line 447

I don't have a reduced testcase, but I do have a stack trace, which I hope is enough for a thread-safety assertion.

I'm guessing this assertion is firing due to the changes in bug 387445, "Remove thread safety from atoms".

Comment 1

[Eli Friedman]

A stack trace is enough, I think.

biesi, know what's going on here?  (Noting Bug 387427.)  Is my patch from that bug to nsCacheMetaData appropriate?  Or is there a more serious problem here?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, I didn't think of the stream pumps...

Yeah, that patch is probably the easiest fix.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Need to fix this for 1.9.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: eli's patch minus the streamconverter part

Comment 5

[Eli Friedman]

Comment on attachment 278423 [details] [diff] [review]
eli's patch minus the streamconverter part

Clearing the request; this bug is already blocking1.9+.

I'll check this in shortly.

Comment 6

[Eli Friedman]

Checked in.