391916 - Download Manager should use the same gradient background color as the Add-ons Manager

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ria Klaassen (not reading all bugmail)]

I think that will look more polished.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=276351
The blue selection color should be somewhat lighter below.

Comment 2

[Shawn Wilsher :sdwilsh]

I'm fairly certain that this would require us to have a fixed height download object, which we didn't really want to do...

Comment 3

[Ryan VanderMeulen [:RyanVM]]

You sure about that? I've got addons with really long descriptions which are taller than other ones in the Addons Manager.

Comment 4

[Shawn Wilsher :sdwilsh]

I've been known to be wrong.  It's still worth investigating! :)

Comment 5

[Ed Lee :Mardak]

It uses this png file to add whiteness on top of the "highlight" color.. but I'm not quite sure how it gets it to fade so quickly.. the image is 300px tall and only starts fading at about 100px.. but the addons richlist item isn't that tall... ???

Comment 6

[Shawn Wilsher :sdwilsh]

I'm inclined to WONTFIX this - right now the richlistbox uses system colors (for example, on mac you can change the selection color to whatever you want), and if we use an image to make a gradient, we lose that.

Comment 7

[Ed Lee :Mardak]

Could do it for windows only.. but seems like os x has it too

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css&rev=1.35&mark=65-67#65

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css&rev=1.39&mark=108-116#108

Comment 8

[Shawn Wilsher :sdwilsh]

Poor OS integration in the add-ons manager doesn't mean I'll take it in the downloads manager ;)

Comment 9

[Ed Lee :Mardak]

Attachment: screenshot of v1

This adds a gradient behind each download item, but you only really see it for the selected one even though the lightblue banded are also faded.

Also, I'm hovering over the cancel button so the paused button is relatively faded for bug 391928.

Comment 10

[Ed Lee :Mardak]

Attachment: screenshot of trunk

For comparison.. open in multiple tabs and switch between them.

Comment 11

[Ed Lee :Mardak]

Attachment: screenshot of v1,trunk windows

Same thing as earlier but on windows. Left side has cancel button hovered.

Comment 12

[Ed Lee :Mardak]

Attachment: screenshot of v1,trunk windows (gif)

Just incase my settings are strange for png..

Comment 13

[Ed Lee :Mardak]

Attachment: v1

I'm not sure if this is right.. using extension's image?

Comment 14

[Shawn Wilsher :sdwilsh]

So how does this look if you change the system color for selection on OS X?

Comment 15

[Ed Lee :Mardak]

On OS X we have a forced color..

  background-color: #EDF3FE;

Comment 16

[Shawn Wilsher :sdwilsh]

Sorry - I thought this was for selected downloads.

Comment 17

[Ed Lee :Mardak]

Oh oops, yeah it is for the selected. Where do you change that?

Comment 18

[Shawn Wilsher :sdwilsh]

System Preferences -> Appearance -> Highlight Color

Comment 19

[Shawn Wilsher :sdwilsh]

Also, your patched does things for non-selected downloads.

Comment 20

[Ed Lee :Mardak]

Attachment: screenshot of colors

Color by domain ?! filetype?! ;) ;) These all have the fading background and use a color based on the selection color.

Comment 21

[Ed Lee :Mardak]

(In reply to comment #18)
> System Preferences -> Appearance -> Highlight Color
That affects selected text.

(In reply to comment #19)
> Also, your patched does things for non-selected downloads.
I know.

Comment 22

[Shawn Wilsher :sdwilsh]

(In reply to comment #21)
> (In reply to comment #18)
> > System Preferences -> Appearance -> Highlight Color
> That affects selected text.
Not just text.

> (In reply to comment #19)
> > Also, your patched does things for non-selected downloads.
> I know.
I think we are having a miscommunication issue :p

Comment 23

[Ed Lee :Mardak]

Does changing the "Highlight Color" do anything other than change the highlight text color... outside of Firefox? The option even says "For selected text". Type in something into the spotlight for system preferences and select text and see the changed highlight color.

We don't lose the selection color anyway by adding in the image. The image is a background gradient that fades in, but it's mostly transparent, so you see through to the selection color.

Just take a look at the chrome file

chrome://mozapps/skin/extensions/itemEnabledFader.png

Comment 24

[Shawn Wilsher :sdwilsh]

Attachment: screenshot of color

Nothing to do with text for me - it's the selected richlistitem.

Comment 25

[Shawn Wilsher :sdwilsh]

but anyway, if this gets ui-r, I'll take it.

Comment 26

[Madhava Enros [:madhava]]

Comment on attachment 301155 [details]
screenshot of v1

This kind of highlighting isn't standard for OSX.  Do we do this in the add-ons manager on OSX?

Comment 27

[Madhava Enros [:madhava]]

Comment on attachment 301159 [details]
screenshot of v1,trunk windows

It looks good on windows. Just not on OSX.

Comment 28

[Ed Lee :Mardak]

Attachment: v1.1

Both winstripe and gnomestripe have the styling, so only those and not os x.

Comment 29

[Shawn Wilsher :sdwilsh]

Comment on attachment 301438 [details] [diff] [review]
v1.1

r=sdwilsh

Comment 30

[Ed Lee :Mardak]

Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.7; previous revision: 1.6
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.29; previous revision: 1.28
done