Closed Bug 391916 Opened 14 years ago Closed 13 years ago

Download Manager should use the same gradient background color as the Add-ons Manager

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: ria.klaassen, Assigned: Mardak)

References

Details

Attachments

(7 files, 1 obsolete file)

I think that will look more polished.
Screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=276351
The blue selection color should be somewhat lighter below.
I'm fairly certain that this would require us to have a fixed height download object, which we didn't really want to do...
You sure about that? I've got addons with really long descriptions which are taller than other ones in the Addons Manager.
I've been known to be wrong.  It's still worth investigating! :)
It uses this png file to add whiteness on top of the "highlight" color.. but I'm not quite sure how it gets it to fade so quickly.. the image is 300px tall and only starts fading at about 100px.. but the addons richlist item isn't that tall... ???
I'm inclined to WONTFIX this - right now the richlistbox uses system colors (for example, on mac you can change the selection color to whatever you want), and if we use an image to make a gradient, we lose that.
Poor OS integration in the add-ons manager doesn't mean I'll take it in the downloads manager ;)
Attached image screenshot of v1
This adds a gradient behind each download item, but you only really see it for the selected one even though the lightblue banded are also faded.

Also, I'm hovering over the cancel button so the paused button is relatively faded for bug 391928.
Attachment #301155 - Flags: ui-review?(madhava)
Attached image screenshot of trunk
For comparison.. open in multiple tabs and switch between them.
Same thing as earlier but on windows. Left side has cancel button hovered.
Attachment #301159 - Flags: ui-review?(madhava)
Just incase my settings are strange for png..
Attached patch v1 (obsolete) — Splinter Review
I'm not sure if this is right.. using extension's image?
So how does this look if you change the system color for selection on OS X?
On OS X we have a forced color..

  background-color: #EDF3FE;
Sorry - I thought this was for selected downloads.
Oh oops, yeah it is for the selected. Where do you change that?
System Preferences -> Appearance -> Highlight Color
Also, your patched does things for non-selected downloads.
Attached image screenshot of colors
Color by domain ?! filetype?! ;) ;) These all have the fading background and use a color based on the selection color.
(In reply to comment #18)
> System Preferences -> Appearance -> Highlight Color
That affects selected text.

(In reply to comment #19)
> Also, your patched does things for non-selected downloads.
I know.
(In reply to comment #21)
> (In reply to comment #18)
> > System Preferences -> Appearance -> Highlight Color
> That affects selected text.
Not just text.

> (In reply to comment #19)
> > Also, your patched does things for non-selected downloads.
> I know.
I think we are having a miscommunication issue :p
Does changing the "Highlight Color" do anything other than change the highlight text color... outside of Firefox? The option even says "For selected text". Type in something into the spotlight for system preferences and select text and see the changed highlight color.

We don't lose the selection color anyway by adding in the image. The image is a background gradient that fades in, but it's mostly transparent, so you see through to the selection color.

Just take a look at the chrome file

chrome://mozapps/skin/extensions/itemEnabledFader.png
Attached image screenshot of color
Nothing to do with text for me - it's the selected richlistitem.
but anyway, if this gets ui-r, I'll take it.
Comment on attachment 301155 [details]
screenshot of v1

This kind of highlighting isn't standard for OSX.  Do we do this in the add-ons manager on OSX?
Attachment #301155 - Flags: ui-review?(madhava) → ui-review-
Comment on attachment 301159 [details]
screenshot of v1,trunk windows

It looks good on windows. Just not on OSX.
Attachment #301159 - Flags: ui-review?(madhava) → ui-review+
Attached patch v1.1Splinter Review
Both winstripe and gnomestripe have the styling, so only those and not os x.
Assignee: nobody → edilee
Attachment #301163 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #301438 - Flags: review?(sdwilsh)
Comment on attachment 301438 [details] [diff] [review]
v1.1

r=sdwilsh
Attachment #301438 - Flags: review?(sdwilsh)
Attachment #301438 - Flags: review+
Attachment #301438 - Flags: approval1.9?
Attachment #301438 - Flags: approval1.9? → approval1.9+
Checking in toolkit/themes/gnomestripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.7; previous revision: 1.6
done
Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css,v  <--  downloads.css
new revision: 1.29; previous revision: 1.28
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.