Remove </xpfe/components/extensions/ (src/nsExtensionManager.js)> from CVS Trunk

VERIFIED FIXED in seamonkey2.0a1

Status

defect
--
trivial
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: sgautherie, Unassigned)

Tracking

Trunk
seamonkey2.0a1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

From
{{
Newsgroups: mozilla.dev.apps.seamonkey
Subject: Re: </xpfe/.../nsExtensionManager.js> ?
}}

I:
[[
(
While working on
Bug 384693 – "Error / Exception / NS_NOINTERFACE / nsExtensionManager.js :: anonymous :: line 2432", when checking for "blocklist"
I noticed that
)

<http://mxr.mozilla.org/seamonkey/find?string=nsExtensionManager.js>
returns
{{
/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
/xpfe/components/extensions/src/nsExtensionManager.js
}}

Do we still need the /xpfe one ?
]]

Neil:
[[
We stopped building it when we switched to toolkit. I don't know if other products still build or need to build it.
]]

Karsten:
[[
I doubt anybody except FF (if so) has ever used it.
]]
Blocks: 380786
Philip:
[[
Actually I can't find it in any of the SeaMonkey 1.0 or 1.1 builds I
have nor in the old Suite 1.8 alphas, nor in 1.7.x.


The one in /xpfe/ appears to be a dummy implementation that does |throw
Components.results.NS_ERROR_NOT_IMPLEMENTED;| for everything.

<http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/components/extensions/src/nsExtensionManager.js&rev=HEAD&mark=1.1>
(install.rdf read hook + stub extension manager implementation for
seamonkey)
- xpinstall hooks for info bar (xpinstall whitelist UI)

<https://bugzilla.mozilla.org/show_bug.cgi?id=242529#c8>

"xpfe/components/extensions/*:
- a stub extension manager implementation for Seamonkey that throws not\
implemented when invoked to force Seamonkey to only recognize install.js
scripts at the top level of xpi files, and ignore extension install.rdf
manifests."

SeaMonkey/XPFE successfully ignores install.rdf without this file though.
]]

Neil:
[[
I said we stopped building it - I never said we packaged it ;-)
]]
cvs is history for development and I don't see that directory in mozilla-central, so it has been fixed since or due to us moving to hg, right?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to comment #2)
> it has been fixed since or due to us moving to hg, right?

You (cvs-)removed the files in bug 383085 comment 27 ;->

V.Fixed.
Status: RESOLVED → VERIFIED
Depends on: 383085
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.