Closed
Bug 391945
Opened 17 years ago
Closed 17 years ago
Staggered headers don't check dotweak properly
Categories
(Bugzilla :: User Interface, defect)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: goobix, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
|
1.04 KB,
patch
|
goobix
:
review+
|
Details | Diff | Splinter Review |
In template/en/default/list/table.html.tmpl :
<tr align="left">
[% IF dotweak %]
<th> </th>
but the conditional is not present on the 2nd row, if staggered headers are used.
ok, first you need some background. 1. this is how staggered should look https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=0;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=1 2. this is how staggered looks with tweak https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=1;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=1 3. this is how tweak normally looks: https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=1;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=0
Attachment #276384 -
Flags: review?(vladd)
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 276384 [details] [diff] [review] add missing stagger bit The first row is ok, we want this on the 2nd row, right?
Attachment #276384 -
Flags: review?(vladd) → review-
Attachment #276384 -
Attachment is obsolete: true
Attachment #276388 -
Flags: review?(vladd)
|
|
Reporter | |
Comment 4•17 years ago
|
||
Comment on attachment 276388 [details] [diff] [review] properly place extra column is not exactly ideal but this matches what we already have and it fixes the bug on 3.0-branch as well.
Attachment #276388 -
Flags: review?(vladd) → review+
|
|
Reporter | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval3.0?
|
||
Updated•17 years ago
|
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
|
|
||
Updated•17 years ago
|
Severity: normal → minor
Comment on attachment 276388 [details] [diff] [review] properly place extra column mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl 1.35 BUGZILLA-3_0-BRANCH: mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl 1.32.2.1
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•