391945 - Staggered headers don't check dotweak properly

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Vlad Dascalu]

In template/en/default/list/table.html.tmpl :

    <tr align="left">
       [% IF dotweak %]
       <th>&nbsp;</th>

but the conditional is not present on the 2nd row, if staggered headers are used.

Comment 1

[timeless]

Attachment: add missing stagger bit

ok, first you need some background.

1. this is how staggered should look
https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=0;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=1

2. this is how staggered looks with tweak
https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=1;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=1

3. this is how tweak normally looks:
https://bugzilla.mozilla.org/colchange.cgi?rememberedquery=bug_id=10000,10001%26tweak=1;column_bug_severity=1;column_priority=1;column_assigned_to=1;column_reporter=1;column_bug_status=1;column_resolution=1;column_op_sys=1;column_short_desc=1;splitheader=0

Comment 2

[Vlad Dascalu]

Comment on attachment 276384 [details] [diff] [review]
add missing stagger bit

The first row is ok, we want this on the 2nd row, right?

Comment 3

[timeless]

Attachment: properly place extra column

Comment 4

[Vlad Dascalu]

Comment on attachment 276388 [details] [diff] [review]
properly place extra column

  is not exactly ideal but this matches what we already have and it fixes the bug on 3.0-branch as well.

Comment 5

[timeless]

Comment on attachment 276388 [details] [diff] [review]
properly place extra column

mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl 	1.35 	  	

BUGZILLA-3_0-BRANCH:
mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl 	1.32.2.1