391955 - Missing string jsObjectExpressionError.title in inspector.properties

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Ronny Perinke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.5pre) Gecko/20070731 Firefox/2.0.0.7pre (Sephiroth/SSE2)
Build Identifier: 

When you have an error in your expression that should be evaluated in DomI, the user should bee notified - but he won't because the string is missing.

Reproducible: Always

Actual Results:  
Error in Error Console:
--------------
Fehler: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle :: getString :: line 17"  data: no]

Error in console is more detailed:
-----
Error in expression.
*** Failed to get string jsObjectExpressionError.title in bundle: chrome://inspector/locale/inspector.properties

Expected Results:  
Dialog box with appropriate info message.

Regression from bug 352990

Comment 1

[Serge Gautherie (:sgautherie)]

Confirming, per looking at that patch and per
http://mxr.mozilla.org/comm-central/search?string=jsObjectExpressionError&case=on&find=%2Fmozilla%2Fextensions%2Finspector%2F

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: cleanup and use the error name for the alert title

Comment 3

[[e-mail]]

Comment on attachment 480448 [details] [diff] [review]
cleanup and use the error name for the alert title

>+    XPCU.getService("@mozilla.org/embedcomp/prompt-service;1",
>+                    "nsIPromptService")
>+      .alert(window, ex.name, ex.message);
[Indentation looks odd. Try an extra two spaces?]

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

> Comment on attachment 480448 [details] [diff] [review]
> cleanup and use the error name for the alert title
> 
> >+    XPCU.getService("@mozilla.org/embedcomp/prompt-service;1",
> >+                    "nsIPromptService")
> >+      .alert(window, ex.name, ex.message);
> [Indentation looks odd. Try an extra two spaces?]

I just split it into two lines.  I'm not a fan of lining up the dots, because the second part isn't analogous to the getService part, because it's not operating on XPCU.

Pushed http://hg.mozilla.org/dom-inspector/rev/c0b6ded88689(In reply to comment #3)

Comment 5

[Colby Russell :crussell (no longer Mozilla-ing)]

> Pushed http://hg.mozilla.org/dom-inspector/rev/c0b6ded88689(In reply to comment
> #3)

That's http://hg.mozilla.org/dom-inspector/rev/c0b6ded88689.