Last Comment Bug 391964 - Spell Check should check the subject line.
: Spell Check should check the subject line.
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Message Display (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: ---
Assigned To: Bruno 'Aqualon' Escherl
:
Mentors:
Depends on:
Blocks: 391969
  Show dependency treegraph
 
Reported: 2007-08-12 13:43 PDT by Bruno 'Aqualon' Escherl
Modified: 2007-10-13 15:57 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Enable spell checking for subject (5.87 KB, patch)
2007-08-12 14:20 PDT, Bruno 'Aqualon' Escherl
neil: superreview+
Details | Diff | Review
Enable spell checking for subject without setting spellcheck="true" (4.76 KB, patch)
2007-08-12 16:01 PDT, Bruno 'Aqualon' Escherl
mnyromyr: review+
bugzilla: superreview+
Details | Diff | Review

Description Bruno 'Aqualon' Escherl 2007-08-12 13:43:39 PDT
This is a port of Thunderbird bug 3459.
Comment 1 Bruno 'Aqualon' Escherl 2007-08-12 14:20:05 PDT
Created attachment 276411 [details] [diff] [review]
Enable spell checking for subject

This patch ports the fix from bug 3459. I'm not sure, if spellcheck="true" is really needed for the msgSubject textbox, spell checking also seems to work without it.
Comment 2 neil@parkwaycc.co.uk 2007-08-12 15:38:20 PDT
(In reply to comment #1)
>I'm not sure, if spellcheck="true" is really needed for the msgSubject textbox,
>spell checking also seems to work without it.
That's because we init spellchecking on startup (if it's enabled in prefs).
spellecheck="true" just causes extra work if spellcheck is off in prefs.
Comment 3 neil@parkwaycc.co.uk 2007-08-12 15:41:34 PDT
Comment on attachment 276411 [details] [diff] [review]
Enable spell checking for subject

sr=me with the spurious attribute removed.
Comment 4 Bruno 'Aqualon' Escherl 2007-08-12 16:01:05 PDT
Created attachment 276425 [details] [diff] [review]
Enable spell checking for subject without setting spellcheck="true"
Comment 5 Karsten Düsterloh 2007-08-30 13:34:19 PDT
Comment on attachment 276425 [details] [diff] [review]
Enable spell checking for subject without setting spellcheck="true"

Landed on trunk, with enableInlineSpellCheck renamed to EnableInlineSpellCheck to follow the prevalent naming scheme (it's just a convenience function, so this difference to TB isn't very important).

Note You need to log in before you can comment on or make changes to this bug.