391975 - nsHttpChannel::Suspend/Resume do the wrong thing with partially cached content

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

if (mTransactionPump)
        return mTransactionPump->Suspend();
    if (mCachePump)
        return mCachePump->Suspend();

When resuming a partial cache entry, we're reading from the cache pump, and we also have a (suspended) transaction pump. So during the time frame when we're reading from the cache, we need to suspend the cache pump rather than the transaction pump.

Comment 1

[:Paolo Amadini]

How does this affect bug 789932 exactly? Is this something we should worry about?

Comment 2

[Patrick McManus [:mcmanus]]

honza, is this fixed?

Comment 3

[Honza Bambas (:mayhemer)]

The report is misguided.  Suspend/Resume on nsInputStreamPump supports counters.  Hence calling Suspend more than once is correct and a pump is resumed only after the equal number of calls to Resume.

So, suspending both while reading partial entry is absolutely correct unless I'm missing something.